Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CVE checks into the build #916

Open
torsten-liermann opened this issue Dec 20, 2024 · 3 comments
Open

Integrate CVE checks into the build #916

torsten-liermann opened this issue Dec 20, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@torsten-liermann
Copy link

The Maven plugin cannot be executed in a secured network. All Maven artifacts are retrieved via a dedicated repository manager. Artifacts from the public network undergo a security review, which is conducted using the Sonatype IQ Server.

Maven is invoked from the command line as follows:

mvn org.openrewrite.maven:rewrite-maven-plugin:5.46.3:run

These artifacts are intercepted by the IQ Server:

org.jetbrains.kotlin : kotlin-compiler-embeddable
io.projectreactor.netty : reactor-netty-core
io.projectreactor.netty : reactor-netty-http

Surely, a similar verification process can be integrated into the build of the Maven plugin and the OpenRewrite software.

Thanks!

@torsten-liermann torsten-liermann added the enhancement New feature or request label Dec 20, 2024
@timtebeek
Copy link
Contributor

hi @torsten-liermann ; thanks for raising your concerns here! On our end we run a weekly job to triage an CVEs reported by https://github.com/dependency-check/dependency-check-gradle, and also maintain a suppressions file with records for those netty items:

<suppress until="2024-12-13Z">
<notes><![CDATA[
file name: reactor-netty-core-1.0.32.jar
]]></notes>
<packageUrl regex="true">^pkg:maven/io\.projectreactor\.netty/reactor\-netty\-core@.*$</packageUrl>
<cve>CVE-2023-34054</cve>
<cve>CVE-2023-34062</cve>
</suppress>
<suppress until="2024-12-13Z">
<notes><![CDATA[
file name: reactor-netty-http-1.0.32.jar
]]></notes>
<packageUrl regex="true">^pkg:maven/io\.projectreactor\.netty/reactor\-netty\-http@.*$</packageUrl>
<cve>CVE-2023-34054</cve>
<cve>CVE-2023-34062</cve>
</suppress>

It's a bit of a long shot, but did you try the version released two days ago as well?
https://github.com/openrewrite/rewrite-maven-plugin/releases/tag/v5.47.0

@timtebeek timtebeek moved this to Backlog in OpenRewrite Dec 20, 2024
@timtebeek timtebeek removed the status in OpenRewrite Dec 20, 2024
@timtebeek timtebeek added the question Further information is requested label Dec 20, 2024
@timtebeek
Copy link
Contributor

I'm also curious to hear what versions would be acceptable to your IQ Server, as we run a different process, but can reasonably bump where needed.

@torsten-liermann
Copy link
Author

torsten-liermann commented Dec 21, 2024

Result of version 5.47.0

org.jetbrains.kotlin:kotlin-compiler-embeddable:1.9.25 => Found security vulnerability CVE-2022-3509 with severity >= 7 (severity = 7.5), Found security vulnerability CVE-2022-3509 with severity < 9 (severity = 7.5)

io.projectreactor.netty:reactor-netty-core:1.0.32 => Found security vulnerability CVE-2023-34054 with severity >= 7 (severity = 7.5), Found security vulnerability CVE-2023-34054 with severity < 9 (severity = 7.5) (better is 1.0.39 .. 1.0.48)

io.projectreactor.netty:reactor-netty-http:1.0.32 => Found security vulnerability CVE-2023-34062 with severity >= 7 (severity = 7.5). Found security vulnerability CVE-2023-34062 with severity < 9 (severity = 7.5) (better is 1.0.39 .. 1.0.48)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

2 participants