Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin autoDetect #619

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add kotlin autoDetect #619

wants to merge 5 commits into from

Conversation

kunli2
Copy link
Contributor

@kunli2 kunli2 commented Aug 21, 2023

Add Kotlin autoDetect to maven plug-in.

@kunli2 kunli2 requested a review from knutwannheden August 21, 2023 21:58
@kunli2 kunli2 marked this pull request as draft August 22, 2023 00:09
@knutwannheden
Copy link
Contributor

@kunli2 As far as I remember this also requires some corresponding changes in moderne-ast-write. Can you look into that and create a corresponding PR?

@kunli2
Copy link
Contributor Author

kunli2 commented Aug 22, 2023

will postpone this PR until we add Kotlin parsing in the maven plug-in.

@timtebeek timtebeek added the enhancement New feature or request label Aug 31, 2023
pom.xml Outdated Show resolved Hide resolved
@timtebeek
Copy link
Contributor

Not quite sure what the current status is on this PR, or why we've held off on

Would we want to add the KotlinParser here directly?

Or do we plan to move to the OmniParser in rewrite-polyglot?

@knutwannheden
Copy link
Contributor

@kunli2 Meanwhile I think we have the Kotlin parser integrated in the Maven plugin, so I think this is something we can merge, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser-kotlin
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants