Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort preconditions by uses-type and uses-method first #122

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Sort preconditions by uses-type and uses-method first #122

merged 3 commits into from
Dec 20, 2024

Conversation

jevanlingen
Copy link
Contributor

What's changed?

Order of precondition is now:

  • new UsesType
  • new UsesMethod
  • Precondition.And
  • Precondtion.Or

What's your motivation?

Less diff changes with previous release, see also:

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek merged commit 98c4659 into main Dec 20, 2024
2 checks passed
@timtebeek timtebeek deleted the sort-precondition-by-type-methods-first branch December 20, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jevanlingen @timtebeek