Orphan processes #35
Merged
Orphan processes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #35 +/- ##
==========================================
+ Coverage 99.16% 99.19% +0.02%
==========================================
Files 4 4
Lines 120 124 +4
Branches 12 12
==========================================
+ Hits 119 123 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Local tests on OSs
|
sadrasabouri
reviewed
Feb 7, 2024
| >>> for i in range(40): | ||
| ... sound_id = play(os.path.join("others", "test.wav"), async_mode=True) | ||
| ... time.sleep(0.5) | ||
| ... stop(sound_id) |
There was a problem hiding this comment.
Is stop here necessary for test?
There was a problem hiding this comment.
This one will be fixed in future PR for handling tests.
sadrasabouri
reviewed
Feb 7, 2024
|
I tested at Ubuntu 22.04 both the package performance and |
sadrasabouri
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#34
What does this implement/fix? Explain your changes.
NavaThread.stopmethod bug fixedAny other comments?