adding new error for error state

Signed-off-by: Sean Li <lnse@amazon.com>
opensearch-project · Oct 23, 2024 · b7ab03f · b7ab03f
1 parent 65c1e78
commit b7ab03f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/src/plugins/query_enhancements/common/index.ts b/src/plugins/query_enhancements/common/index.ts
@@ -6,3 +6,4 @@
 export * from './constants';
 export * from './types';
 export * from './utils';
+export * from './errors';
diff --git a/src/plugins/query_enhancements/server/routes/index.ts b/src/plugins/query_enhancements/server/routes/index.ts
@@ -85,8 +85,14 @@ export function defineSearchStrategyRouteProvider(logger: Logger, router: IRoute
           const queryRes: IDataFrameResponse = await searchStrategy.search(context, req as any, {});
           return res.ok({ body: { ...queryRes } });
         } catch (err) {
+          let error;
+          try {
+            error = JSON.parse(err.message);
+          } catch (e) {
+            error = err;
+          }
           return res.custom({
-            statusCode: err.name,
+            statusCode: error.status,
             body: err.message,
           });
         }

diff --git a/src/plugins/query_enhancements/server/search/sql_async_search_strategy.ts b/src/plugins/query_enhancements/server/search/sql_async_search_strategy.ts
@@ -14,7 +14,13 @@ import {
   createDataFrame,
 } from '../../../data/common';
 import { Facet } from '../utils';
-import { buildQueryStatusConfig, getFields, handleFacetError, SEARCH_STRATEGY } from '../../common';
+import {
+  buildQueryStatusConfig,
+  getFields,
+  handleFacetError,
+  SEARCH_STRATEGY,
+  PollingResponseError,
+} from '../../common';
 
 export const sqlAsyncSearchStrategyProvider = (
   config$: Observable<SharedGlobalConfig>,
@@ -78,13 +84,8 @@ export const sqlAsyncSearchStrategyProvider = (
               body: dataFrame,
             } as IDataFrameResponse;
           } else if (queryStatus?.toUpperCase() === 'FAILED') {
-            return {
-              type: DATA_FRAME_TYPES.POLLING,
-              status: 'failed',
-              body: {
-                error: new Error(`JOB: ${pollQueryResultsParams.queryId} failed`),
-              },
-            } as IDataFrameResponse;
+            const error = new PollingResponseError(queryStatusResponse.data.error, 500);
+            throw error;
           }
 
           return {