Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Add permission setting for workspace create update page #6380

Closed
wanglam opened this issue Apr 9, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@wanglam
Copy link
Contributor

wanglam commented Apr 9, 2024

Is your feature request related to a problem? Please describe.

In #6052, we add workspace permission control logic. User can create a workspace with permission control by calling workspace create or update API. For most users, calling workspace related API won't be a convenient way. We can add a permission setting section in workspace create and update form. For workspace create page, the workspace create API will automatic grant creator as workspace admin. For workspace update page, we need to keep at least one admin permission to ensure workspace can be controlled by some user.

Describe the solution you'd like

Since workspace CRUD API already support creating and updating workspace, we only need to change the UI side. We prefer adding a permission setting tab in workspace form. The user can set user and group permission in the permission tab. The permission setting value will be send to the workspace create API after create button clicked. For workspace update page, the fetched workspace permission setting will be filled in the permission setting tab. User can modify the settings, and then will call workspace update API after update button clicked.

Describe alternatives you've considered

N/A

Additional context

#6051

@wanglam
Copy link
Contributor Author

wanglam commented Apr 16, 2024

A part of #4944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants