Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [MDS] data source version with pre-release is not compatible for all plugins #8567

Open
Hailong-am opened this issue Oct 12, 2024 · 2 comments
Labels
bug Something isn't working multiple datasource multiple datasource project

Comments

@Hailong-am
Copy link
Collaborator

Describe the bug

When i add data source with version 3.0.0-snapshot, this data source will not available in data source selector as it does not satisfies the semver version check.

semver.satisfies('3.0.0-snapshot','>1.0.0');

# this will return false

if (pluginManifest.hasOwnProperty('supportedOSDataSourceVersions')) {
fetchedDataSources = fetchedDataSources.filter((dataSource) =>
semver.satisfies(
dataSource.datasourceversion,
pluginManifest.supportedOSDataSourceVersions
)
);
}
setDataSources(fetchedDataSources);

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

*Expected behavior

3.0.0-snapshot should be treated as version 3.0.0

OpenSearch Version
Please list the version of OpenSearch being used.

Dashboards Version
Please list the version of OpenSearch Dashboards being used.

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@Hailong-am Hailong-am added bug Something isn't working untriaged labels Oct 12, 2024
@zhyuanqi zhyuanqi added multiple datasource multiple datasource project and removed untriaged labels Oct 21, 2024
@zhyuanqi
Copy link
Collaborator

@zhongnansu Wonder if this is an expected behavior?

@zhongnansu
Copy link
Member

@zhongnansu Wonder if this is an expected behavior?

@ZilongX Zilong might have better answer fort this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

3 participants