[CVE-2022-29622] resolve formidable to ^3.2.4 #2710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the latest superagent still uses formidable@2.0.1 which causes the security issue. https://github.com/visionmedia/superagent/blob/e8d532632bea846e6a8c7677a268dca3641271e7/package.json#L27 Formidable bump to v3.2.4 includes breaking changes: https://github.com/node-formidable/formidable/blob/master/CHANGELOG.md In this PR, we resolve formidable to 3.2.4+. The fix will not be backported to 2.x. Issue Resolved: opensearch-project#1593 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
resolve-formidable
branch
from
0bfb7ee to
a384869
Compare
|
this should require code changes correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the latest superagent still uses formidable@2.0.1 which causes the security issue.
https://github.com/visionmedia/superagent/blob/e8d532632bea846e6a8c7677a268dca3641271e7/package.json#L27
Formidable bump to v3.2.4 includes breaking changes: https://github.com/node-formidable/formidable/blob/master/CHANGELOG.md
In this PR, we resolve formidable to 3.2.4+. The fix will not be backported to 2.x.
Issues Resolved
#1593
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr