Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Add Workspace filter to saved objects management page #6458

Merged
merged 16 commits into from
Apr 17, 2024

Conversation

Hailong-am
Copy link
Collaborator

Description

This PR follows up #6225 add workspace filter into saved objects page, so that user could filter saved objects by workspace.

Issues Resolved

#6098

Screenshot

Screen.Recording.2024-04-15-2.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am and others added 2 commits April 15, 2024 22:58
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am changed the title Add Workspace filter to saved objects management page [Workspace] Add Workspace filter to saved objects management page Apr 16, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Apr 16, 2024
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Apr 16, 2024
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am and others added 2 commits April 17, 2024 11:30
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@ZilongX ZilongX merged commit 9408e49 into opensearch-project:main Apr 17, 2024
65 checks passed
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024
…ensearch-project#6458)

* Add workspace filter into saved objects page (opensearch-project#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (opensearch-project#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
…ensearch-project#6458)

* Add workspace filter into saved objects page (opensearch-project#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (opensearch-project#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 9408e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Hailong-am added a commit to ruanyl/OpenSearch-Dashboards that referenced this pull request Apr 22, 2024
…t page (#6… (#334)

* [Workspace] Add Workspace filter to saved objects management page (opensearch-project#6458)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>

* fix empty workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Apr 23, 2024
) (#6580)

* Add workspace filter into saved objects page (#211)

* Add workspace column/filter into saved objects page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix failed test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

move workspace column to its own folder

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* default workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

remove hide import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace default workspace with public workspace (#322)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add workspace filter

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* revert query params change

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* udpate test case name to more clear

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add changelog

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update fetchExportByTypeAndSearch parameter

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove virtrual public workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix public workspace query when permission is not enabled

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* home dashboards/listing page only show public workspace data

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add more test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 9408e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants