Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] fix the UI of delete modal in the save objects(assets) page #8237

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Sep 19, 2024

Description

This pr fixes the UI of delete modal in the save objects(assets) page by [issue 300-303]:

  1. Change "saved objects" to "assets" in the Delete modal
  2. Swap the "ID" column with the title column and make the modal wider
  3. fix the bug of pagination alignment and remove the bullet point
  4. Capitalize both letters in "ID" column title

Screenshot

before:
截屏2024-09-19 15 20 39

after:
1

Changelog

  • fix: fix the UI of delete modal in the save objects(assets) page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe
Copy link
Member

@kgcreative So no matter new home feature is turned on or off, we will use the term assets instead of saved objects?

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.90%. Comparing base (cea39b8) to head (df24abf).
Report is 180 commits behind head on main.

Files with missing lines Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8237      +/-   ##
==========================================
- Coverage   64.05%   60.90%   -3.16%     
==========================================
  Files        3741     3741              
  Lines       88635    88683      +48     
  Branches    13804    13817      +13     
==========================================
- Hits        56775    54012    -2763     
- Misses      31262    31331      +69     
- Partials      598     3340    +2742     
Flag Coverage Δ
Linux_1 28.84% <0.00%> (-1.23%) ⬇️
Linux_2 56.33% <ø> (-2.50%) ⬇️
Linux_3 37.77% <0.00%> (-2.61%) ⬇️
Linux_4 29.81% <0.00%> (-1.65%) ⬇️
Windows_1 28.85% <0.00%> (-1.23%) ⬇️
Windows_2 56.28% <ø> (-2.50%) ⬇️
Windows_3 37.77% <0.00%> (-2.61%) ⬇️
Windows_4 29.81% <0.00%> (-1.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgcreative
Copy link
Member

@kgcreative So no matter new home feature is turned on or off, we will use the term assets instead of saved objects?

Yes -- we may need to alias some of the old references though

</EuiConfirmModal>
</EuiButtonEmpty>

<EuiButton type="submit" onClick={onConfirm} fill color="danger">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable the button while Deleting...?

AMoo-Miki
AMoo-Miki previously approved these changes Oct 4, 2024
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants