-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] fix the UI of delete modal in the save objects(assets) page #8237
base: main
Are you sure you want to change the base?
[workspace] fix the UI of delete modal in the save objects(assets) page #8237
Conversation
@kgcreative So no matter new home feature is turned on or off, we will use the term |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8237 +/- ##
==========================================
- Coverage 64.05% 60.90% -3.16%
==========================================
Files 3741 3741
Lines 88635 88683 +48
Branches 13804 13817 +13
==========================================
- Hits 56775 54012 -2763
- Misses 31262 31331 +69
- Partials 598 3340 +2742
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes -- we may need to alias some of the old references though |
</EuiConfirmModal> | ||
</EuiButtonEmpty> | ||
|
||
<EuiButton type="submit" onClick={onConfirm} fill color="danger"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we disable the button while Deleting...
?
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
df24abf
to
dd520c2
Compare
Description
This pr fixes the UI of delete modal in the save objects(assets) page by [issue 300-303]:
Screenshot
before:
after:
Changelog
Check List
yarn test:jest
yarn test:jest_integration