Saved queries new UI

[amsiglan]

Description

This PR updates the UI for saved queries to use Flyouts which give more surface to search and categorize the queries as well as introduce more options when saving them.

Screenshot

• Saved queries action popup

• Save query action item when clicked opens

• Open query action item when clicked opens

• Templates tab (Note: these queries cannot be deleted from UI)

Testing the changes

Tested change with local setup.

Changelog

• feat: Enhances the saved query UX

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 6.72646% with 208 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (9a25d0d) to head (5a21c1d).

Files with missing lines	Patch %	Lines
...lugins/data/public/ui/saved_query_form/helpers.tsx	0.00%	64 Missing ⚠️
...ui/saved_query_flyouts/open_saved_query_flyout.tsx	0.00%	63 Missing ⚠️
...public/ui/saved_query_flyouts/saved_query_card.tsx	0.00%	42 Missing ⚠️
...ry_management/saved_query_management_component.tsx	21.42%	10 Missing and 1 partial ⚠️
...ta/public/query/saved_query/saved_query_service.ts	58.82%	4 Missing and 3 partials ⚠️
...ublic/ui/saved_query_flyouts/save_query_flyout.tsx	0.00%	7 Missing ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx	0.00%	6 Missing ⚠️
...ugins/data/public/ui/filter_bar/filter_options.tsx	20.00%	2 Missing and 2 partials ⚠️
...ata/public/ui/saved_query_form/save_query_form.tsx	0.00%	3 Missing ⚠️
...nagement/delete_saved_query_confirmation_modal.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8469      +/-   ##
==========================================
- Coverage   60.84%   60.74%   -0.11%     
==========================================
  Files        3793     3798       +5     
  Lines       90486    90646     +160     
  Branches    14212    14254      +42     
==========================================
+ Hits        55057    55061       +4     
- Misses      31939    32089     +150     
- Partials     3490     3496       +6     

Flag	Coverage Δ
Linux_1	29.07% <0.00%> (-0.01%)	⬇️
Linux_2	56.39% <ø> (ø)
Linux_3	37.57% <6.72%> (-0.10%)	⬇️
Linux_4	29.83% <0.00%> (-0.01%)	⬇️
Windows_1	29.08% <0.00%> (-0.01%)	⬇️
Windows_2	56.35% <ø> (ø)
Windows_3	37.57% <6.72%> (-0.10%)	⬇️
Windows_4	29.83% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ashwin-pc]

Didnt get a chance to review the whole thing yet. But a quick question on saved query templates. I see you added the tab, but I couldnt find a way in the UI to create them. Also if our plan is to include them dynamically, can we hide the tab if there arent any present? Having an empty tab there for most users is bad UX

[amsiglan]

Didnt get a chance to review the whole thing yet. But a quick question on saved query templates. I see you added the tab, but I couldnt find a way in the UI to create them. Also if our plan is to include them dynamically, can we hide the tab if there arent any present? Having an empty tab there for most users is bad UX

Will follow up with another PR to update the UI with either:

• Add a way to support template creation OR
• Hide the template tab when there are no templates

Another angle is that now since we will always have some sample queries that we show where there are no results, we could package them as templates as well.

Will work on the best path forward and create a follow up PR

[virajsanghvi]

There are tests failing related to saved queries.

Also, we've added a lot of code without tests - how are we tracking following up with those tests?

[virajsanghvi]

what if there is an error?

[amsiglan]

It will show no results which is fine since user will simply need to change the search query

[amsiglan]

There are tests failing related to saved queries.

Also, we've added a lot of code without tests - how are we tracking following up with those tests?

Let me add a task on myself to add new tests

[virajsanghvi]

I did not have time to pull this down to validate, and looks like there are still some more cases of text to be localized, but approving assuming that and unit tests will be followed up with.

[virajsanghvi]

is this label presented to customers as should it be localized?

[ananzh]

So we have two places 1) click showFilterActions button and 2) the new three dot one to save queries? What is the purpose or usage pain to resolve for adding another save query? are we going to remove the old one to make the new one the only place to save query?

[amsiglan]

So we have two places 1) click showFilterActions button and 2) the new three dot one to save queries? What is the purpose or usage pain to resolve for adding another save query? are we going to remove the old one to make the new one the only place to save query?

We are replacing the old button in both the places, the one inside the filter options will also show the two options

• Save query and Open query

[ananzh]

So we have two places 1) click showFilterActions button and 2) the new three dot one to save queries? What is the purpose or usage pain to resolve for adding another save query? are we going to remove the old one to make the new one the only place to save query?

We are replacing the old button in both the places, the one inside the filter options will also show the two options

• Save query and Open query

Got it. Haven't got time to review it in details, only verify the changes with query enhancement and MDS enabled. Since you have resolve multiple people's comments, I will approve to unblock. Will reach out to you there is any concerns in the future.