Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS] Mute the non-mds endpoints for direct query data connections #8537

Merged
merged 4 commits into from
Oct 15, 2024
Merged

[MDS] Mute the non-mds endpoints for direct query data connections #8537

merged 4 commits into from
Oct 15, 2024

Conversation

RyanL1997
Copy link
Contributor

Description

  • Mute the non-mds endpoints for direct query data connections when MDS is enabled
  • Use mds data connection endpoint instead for fetching local cluster direct query content

Issues Resolved

Testing the changes

Changelog

  • fix: [MDS] Mute the non-mds endpoints for direct query data connections

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@RyanL1997
Mute the non-mds endpoints for direct query data connections when MDS…
d9d1782 
… enabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Handle the case for local cluster too
256bc2a 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Handle the case for local cluster 2
0409a09 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997 RyanL1997 marked this pull request as ready for review October 10, 2024 00:06
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (9eae148) to head (1dad59b).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
.../data_source_management/public/components/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8537   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3769     3769           
  Lines       89508    89508           
  Branches    14013    14013           
=======================================
  Hits        54541    54541           
  Misses      31557    31557           
  Partials     3410     3410
Flag Coverage Δ
Linux_1 29.00% <0.00%> (ø)
Linux_2 56.25% <ø> (ø)
Linux_3 37.75% <0.00%> (ø)
Linux_4 29.91% <0.00%> (ø)
Windows_1 29.02% <0.00%> (ø)
Windows_2 56.20% <ø> (ø)
Windows_3 37.75% <0.00%> (ø)
Windows_4 29.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 47ae28b into opensearch-project:main Oct 15, 2024
69 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
@github-actions @opensearch-changeset-bot
[MDS] Mute the non-mds endpoints for direct query data connections (#…
21c5c1d 
…8537)

* Mute the non-mds  endpoints for direct query data connections when MDS enabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster too

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #8537 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 47ae28b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 15, 2024
Merged
BionIT pushed a commit that referenced this pull request Oct 16, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[MDS] Mute the non-mds endpoints for direct query data connections (#…
8dbad3f 
…8537) (#8597)

* Mute the non-mds  endpoints for direct query data connections when MDS enabled



* Handle the case for local cluster too



* Handle the case for local cluster 2



* Changeset file for PR #8537 created/updated

---------



(cherry picked from commit 47ae28b)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
@github-actions @opensearch-changeset-bot
[MDS] Mute the non-mds endpoints for direct query data connections (#…
be60d90 
…8537)

* Mute the non-mds  endpoints for direct query data connections when MDS enabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster too

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #8537 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 47ae28b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2024
Merged
mengweieric pushed a commit that referenced this pull request Oct 18, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[MDS] Mute the non-mds endpoints for direct query data connections (#…
e9c9983 
…8537) (#8637)

* Mute the non-mds  endpoints for direct query data connections when MDS enabled



* Handle the case for local cluster too



* Handle the case for local cluster 2



* Changeset file for PR #8537 created/updated

---------



(cherry picked from commit 47ae28b)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
@RyanL1997 @opensearch-changeset-bot @sejli
[MDS] Mute the non-mds endpoints for direct query data connections (o…
5d9b4bb 
…pensearch-project#8537)

* Mute the non-mds  endpoints for direct query data connections when MDS enabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster too

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Handle the case for local cluster 2

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR opensearch-project#8537 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BionIT BionIT BionIT approved these changes

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.17 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanL1997 @BionIT @zengyan-amazon @mengweieric