-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Mute the non-mds endpoints for direct query data connections #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 10, 2024 00:06
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8537 +/- ##
=======================================
Coverage 60.93% 60.93%
=======================================
Files 3769 3769
Lines 89508 89508
Branches 14013 14013
=======================================
Hits 54541 54541
Misses 31557 31557
Partials 3410 3410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BionIT
approved these changes
Oct 14, 2024
zengyan-amazon
approved these changes
Oct 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…8537) * Mute the non-mds endpoints for direct query data connections when MDS enabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster too Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR #8537 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 47ae28b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Oct 16, 2024
…8537) (#8597) * Mute the non-mds endpoints for direct query data connections when MDS enabled * Handle the case for local cluster too * Handle the case for local cluster 2 * Changeset file for PR #8537 created/updated --------- (cherry picked from commit 47ae28b) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…8537) * Mute the non-mds endpoints for direct query data connections when MDS enabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster too Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR #8537 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 47ae28b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
Oct 18, 2024
…8537) (#8637) * Mute the non-mds endpoints for direct query data connections when MDS enabled * Handle the case for local cluster too * Handle the case for local cluster 2 * Changeset file for PR #8537 created/updated --------- (cherry picked from commit 47ae28b) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…pensearch-project#8537) * Mute the non-mds endpoints for direct query data connections when MDS enabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster too Signed-off-by: Ryan Liang <jiallian@amazon.com> * Handle the case for local cluster 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR opensearch-project#8537 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration