Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add Footer Bar for Single Line Editor #8565

Merged
merged 9 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. initial commit for single line editor footer

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4c4def0 View commit details
    Browse the repository at this point in the history
  2. fixing styling and functionality

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a0c931e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    21cae71 View commit details
    Browse the repository at this point in the history
  4. fixing bug with error not showing up in footer

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8bd7627 View commit details
    Browse the repository at this point in the history
  5. fixing loading state thanks ashwinpc

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    64b5969 View commit details
    Browse the repository at this point in the history
  6. trying to surface errors

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    65c1e78 View commit details
    Browse the repository at this point in the history
  7. adding new error for error state

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b7ab03f View commit details
    Browse the repository at this point in the history
  8. Revert "fixing loading state thanks ashwinpc"

    This reverts commit 64b5969.
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cf676d4 View commit details
    Browse the repository at this point in the history
  9. correctly passing async search strat errors

    Signed-off-by: Sean Li <lnse@amazon.com>
    sejli committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c8278f3 View commit details
    Browse the repository at this point in the history