Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace]Fix workspace selector style alignment #8592

Merged
merged 6 commits into from
Oct 18, 2024
Merged

[workspace]Fix workspace selector style alignment #8592

merged 6 commits into from
Oct 18, 2024

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Oct 15, 2024 •
edited
Loading

Description

This pr addresses following issues to the workspace selector:

  1. workspace content are first sorted by most recently visited. Unvisited workspaces will be sorted alphabetically
  2. workspace selector has the similar style with data source selector
  3. resolve issues affecting the display of the workspace selector on mobile

the background color of the workspace selector takes euiSideNavBackgroundColor
the background color of data source selector takes euiHeaderBackgroundColor

Screenshot

  1. workspace content
截屏2024-10-15 14 25 45
  1. on mobile
截屏2024-10-15 13 46 43
  1. In theme V7
    workspace selector：
v7

Dark mode:
截屏2024-10-16 10 03 28

data source selector：
v7-data

  1. In theme V9
    workspace selector：
v9

Dark mode:
9

data source selector：
v9-data

  1. In theme next
    workspace selector：
next

Dark mode:
截屏2024-10-16 10 02 35

data source selector：
next-data

Changelog

  • fix: workspace selector style alignment

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 15, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8592 created/updated
bacda8a
@Qxisylolo Qxisylolo force-pushed the fix/workspace_selector_style_alignment branch from bacda8a to c32b516 Compare October 15, 2024 06:49
@Qxisylolo Qxisylolo marked this pull request as ready for review October 15, 2024 06:50
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 15, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8592 created/updated
949796e
@Qxisylolo Qxisylolo force-pushed the fix/workspace_selector_style_alignment branch from 949796e to f82bb19 Compare October 15, 2024 07:03
SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 15, 2024
View reviewed changes
Hailong-am
Hailong-am previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried with dark mode?

@Qxisylolo
Copy link
Contributor Author

have you tried with dark mode?

Please check the new screenshots, all look fine~

ruanyl
ruanyl reviewed Oct 16, 2024
View reviewed changes
src/plugins/workspace/public/components/workspace_picker_content/workspace_picker_content.tsx Outdated
Comment on lines 81 to 83
accessTimeDescription: recentWorkspace
? `Viewed ${moment(recentWorkspace.timestamp).fromNow()}`
: `Not visited recently`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs i18n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, already updated

@Qxisylolo Qxisylolo dismissed stale reviews from Hailong-am and SuZhou-Joe via 31f95a2 October 16, 2024 08:23
@Qxisylolo Qxisylolo force-pushed the fix/workspace_selector_style_alignment branch from 79d8f31 to 31f95a2 Compare October 16, 2024 08:23
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 16, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8592 created/updated
38406ed
SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 17, 2024
View reviewed changes
ruanyl
ruanyl previously approved these changes Oct 17, 2024
View reviewed changes
SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 17, 2024
View reviewed changes
@Qxisylolo
fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabe…
ba44036 
…tical

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
align styles, typo
8461e6b 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
resolve comment
341428e 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
add i18n
b4b35cd 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
fix i18n in test
32a78cd 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo dismissed stale reviews from SuZhou-Joe and ruanyl via 32a78cd October 18, 2024 02:47
@Qxisylolo Qxisylolo force-pushed the fix/workspace_selector_style_alignment branch from d5b806a to 32a78cd Compare October 18, 2024 02:47
@SuZhou-Joe SuZhou-Joe merged commit e09c137 into opensearch-project:main Oct 18, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
@github-actions @opensearch-changeset-bot
[workspace]Fix workspace selector style alignment (#8592)
85d8d8e 
* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* align styles, typo

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* resolve comment

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* add i18n

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* fix i18n in test

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR #8592 created/updated

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e09c137)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 18, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[workspace]Fix workspace selector style alignment (#8592) (#8642)
bb640f4 
* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical



* align styles, typo



* resolve comment



* add i18n



* fix i18n in test



* Changeset file for PR #8592 created/updated

---------



(cherry picked from commit e09c137)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
@Qxisylolo @opensearch-changeset-bot @amsiglan
[workspace]Fix workspace selector style alignment (opensearch-project…
5782afa 
…#8592)

* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* align styles, typo

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* resolve comment

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* add i18n

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* fix i18n in test

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR opensearch-project#8592 created/updated

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
@Qxisylolo @opensearch-changeset-bot @sejli
[workspace]Fix workspace selector style alignment (opensearch-project…
6b1d465 
…#8592)

* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* align styles, typo

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* resolve comment

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* add i18n

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* fix i18n in test

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR opensearch-project#8592 created/updated

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@Hailong-am Hailong-am Hailong-am approved these changes

@ruanyl ruanyl ruanyl left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x valued-contributor workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qxisylolo @ruanyl @SuZhou-Joe @Hailong-am