-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]Fix workspace selector style alignment #8592
[workspace]Fix workspace selector style alignment #8592
Conversation
bacda8a
to
c32b516
Compare
949796e
to
f82bb19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried with dark mode?
Please check the new screenshots, all look fine~ |
accessTimeDescription: recentWorkspace | ||
? `Viewed ${moment(recentWorkspace.timestamp).fromNow()}` | ||
: `Not visited recently`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs i18n?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, already updated
79d8f31
to
31f95a2
Compare
…tical Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
d5b806a
to
32a78cd
Compare
* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical Signed-off-by: Qxisylolo <qianxisy@amazon.com> * align styles, typo Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comment Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add i18n Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix i18n in test Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #8592 created/updated --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e09c137) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical * align styles, typo * resolve comment * add i18n * fix i18n in test * Changeset file for PR #8592 created/updated --------- (cherry picked from commit e09c137) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…#8592) * fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical Signed-off-by: Qxisylolo <qianxisy@amazon.com> * align styles, typo Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comment Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add i18n Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix i18n in test Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#8592 created/updated --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…#8592) * fix/workspace_selector_style_alignment, sortByRecentVisitedAndAlphabetical Signed-off-by: Qxisylolo <qianxisy@amazon.com> * align styles, typo Signed-off-by: Qxisylolo <qianxisy@amazon.com> * resolve comment Signed-off-by: Qxisylolo <qianxisy@amazon.com> * add i18n Signed-off-by: Qxisylolo <qianxisy@amazon.com> * fix i18n in test Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR opensearch-project#8592 created/updated --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This pr addresses following issues to the workspace selector:
the background color of the workspace selector takes euiSideNavBackgroundColor
the background color of data source selector takes euiHeaderBackgroundColor
Screenshot
workspace selector:
Dark mode:
data source selector:
workspace selector:
Dark mode:
data source selector:
workspace selector:
Dark mode:
data source selector:
Changelog
Check List
yarn test:jest
yarn test:jest_integration