Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Workspace assets page crashed after library_write permission revoked #8648

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Reproduce steps:

  1. Login with admin user
  2. Create a test_user
  3. Assign test_user to specific workspace with Read and write permission
  4. Login with test_user in another window and open assets page in specific workspace
  5. Open copy assets modal select current workspace
  6. Revoke "Read and write" for test_user in another window
  7. Click "Copy" button in test_user window you will see screenshot like below
    Error screenshot:
    image

Issues Resolved

Screenshot

2024-10-18.16.14.46.mp4

Testing the changes

Changelog

  • fix: [Workspace] Workspace assets page crashed after library_write permission revoked

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (32b11de) to head (9381183).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8648      +/-   ##
==========================================
+ Coverage   60.86%   60.88%   +0.01%     
==========================================
  Files        3790     3790              
  Lines       90235    90253      +18     
  Branches    14144    14153       +9     
==========================================
+ Hits        54924    54948      +24     
+ Misses      31846    31834      -12     
- Partials     3465     3471       +6     
Flag Coverage Δ
Linux_1 29.10% <0.00%> (+0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <0.00%> (-0.01%) ⬇️
Linux_4 29.81% <88.88%> (+0.01%) ⬆️
Windows_1 29.11% <0.00%> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <0.00%> (-0.01%) ⬇️
Windows_4 29.81% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 18, 2024
Hailong-am
Hailong-am previously approved these changes Oct 18, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe dismissed stale reviews from Hailong-am and themself via 9381183 October 18, 2024 12:00
@SuZhou-Joe SuZhou-Joe merged commit 0e00abf into opensearch-project:main Oct 18, 2024
66 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
…ion revoked (#8648)

* fix copy issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #8648 created/updated

* fix: snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0e00abf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Oct 18, 2024
…ion revoked (#8648) (#8654)

* fix copy issue



* Changeset file for PR #8648 created/updated

* fix: snapshot



---------





(cherry picked from commit 0e00abf)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
…ion revoked (opensearch-project#8648)

* fix copy issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#8648 created/updated

* fix: snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…ion revoked (opensearch-project#8648)

* fix copy issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#8648 created/updated

* fix: snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants