[workspace] update search bar layout and align workspace selector #8649
+191
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
opensearch-changeset-bot bot
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 18, 2024
Hailong-am
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8649 +/- ##
=======================================
Coverage 60.86% 60.86%
=======================================
Files 3793 3793
Lines 90381 90386 +5
Branches 14185 14190 +5
=======================================
+ Hits 55006 55010 +4
+ Misses 31898 31897 -1
- Partials 3477 3479 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
search_bar_layout
branch
from
6149e21
to
721eb42
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq and
bandinib-amzn
as code owners
Hailong-am
requested review from
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: Hailong Cui <ihailong@amazon.com>
May I know if this misalignment is by intension?
|
SuZhou-Joe
reviewed
Oct 21, 2024
| flush="both" | ||
| {...homeLinkProps} | ||
| onClick={onIconClick} | ||
| className="homeIcon" |
There was a problem hiding this comment.
Suggested change
| className="homeIcon" | |
| className="navGroupEnabledHomeIcon" |
Will the class name conflict with the existing homeIcon?
There was a problem hiding this comment.
updated to navGroupEnabledHomeIcon as suggested.
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Yes, |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
approved these changes
Oct 22, 2024
ruanyl
reviewed
Oct 22, 2024
| {isPopoverOpen && ( | ||
| <EuiPopover | ||
| panelStyle={{ minWidth: '400px', minHeight: '100px' }} | ||
| button={<></>} |
There was a problem hiding this comment.
Q: why using <></> as the popover anchor?
There was a problem hiding this comment.
Popover will always show with its anchor, the purpose of this will make it looks like only popover displayed. And button is required, so i put an empty element here.
ruanyl
approved these changes
Oct 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
) * update search bar layout Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #8649 created/updated * update search bar layout Signed-off-by: Hailong Cui <ihailong@amazon.com> * update test case Signed-off-by: Hailong Cui <ihailong@amazon.com> * style update Signed-off-by: Hailong Cui <ihailong@amazon.com> * typo Signed-off-by: Hailong Cui <ihailong@amazon.com> * support search nav items by its parent title Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 79fed30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 23, 2024
) (#8687) * update search bar layout * Changeset file for PR #8649 created/updated * update search bar layout * update test case * style update * typo * support search nav items by its parent title * address review comments --------- (cherry picked from commit 79fed30) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Before
After
items show with normal font weight
workspace selector align with left nav
Testing the changes
yarn startChangelog
Check List
yarn test:jestyarn test:jest_integration