Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix Queries of Unsupported types appearing on Visualize & Vis Builder Search Bar #8656

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 84f925b from #8601.

… Search Bar (#8601)

* Fix Queries of Unsupported types appearing on Visualize

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Fix PR comments

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit 84f925b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (d47ecc0) to head (7701cb4).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../public/query/query_string/query_string_manager.ts 40.90% 12 Missing and 1 partial ⚠️
src/plugins/data/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8656      +/-   ##
==========================================
- Coverage   60.96%   60.95%   -0.01%     
==========================================
  Files        3784     3784              
  Lines       90183    90207      +24     
  Branches    14124    14128       +4     
==========================================
+ Hits        54978    54986       +8     
- Misses      31741    31755      +14     
- Partials     3464     3466       +2     
Flag Coverage Δ
Linux_1 29.12% <12.50%> (-0.01%) ⬇️
Linux_2 56.53% <ø> (ø)
Linux_3 37.74% <41.66%> (-0.01%) ⬇️
Linux_4 30.02% <12.50%> (-0.01%) ⬇️
Windows_1 29.14% <12.50%> (-0.01%) ⬇️
Windows_2 56.48% <ø> (ø)
Windows_3 37.74% <41.66%> (+<0.01%) ⬆️
Windows_4 30.02% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit c05bdf6 into 2.x Oct 18, 2024
68 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8601-to-2.x branch October 18, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover-next failed changeset v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants