Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix Documentation for various languages in Discover #8657

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e5b7067 from #8636.

* Fix Documentation for various languages in Discover

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Update Snapshots

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Update the Lucene Language Reference

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e5b7067)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 18, 2024
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming ci passes

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (d47ecc0) to head (ab3d643).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...string/language_service/lib/language_reference.tsx 16.66% 5 Missing ⚠️
...ng/language_service/lib/dql_language_reference.tsx 42.85% 4 Missing ⚠️
...language_service/lib/lucene_language_reference.tsx 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8657      +/-   ##
==========================================
- Coverage   60.96%   60.95%   -0.01%     
==========================================
  Files        3784     3786       +2     
  Lines       90183    90189       +6     
  Branches    14124    14124              
==========================================
+ Hits        54978    54979       +1     
- Misses      31741    31746       +5     
  Partials     3464     3464              
Flag Coverage Δ
Linux_1 29.13% <22.72%> (+<0.01%) ⬆️
Linux_2 56.53% <ø> (ø)
Linux_3 37.74% <40.90%> (-0.01%) ⬇️
Linux_4 30.03% <22.72%> (+<0.01%) ⬆️
Windows_1 29.15% <22.72%> (+<0.01%) ⬆️
Windows_2 56.48% <ø> (ø)
Windows_3 37.74% <40.90%> (-0.01%) ⬇️
Windows_4 30.03% <22.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi virajsanghvi merged commit dff25a9 into 2.x Oct 18, 2024
69 of 72 checks passed
@github-actions github-actions bot deleted the backport/backport-8636-to-2.x branch October 18, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants