Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x-manual-backport][Discover] Add Footer Bar for Single Line Editor (#8565) #8691

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 23, 2024

Backport PR:

#8565

From the original PR:

  • initial commit for single line editor footer

  • fixing styling and functionality

  • Changeset file for PR [Discover] Add Footer Bar for Single Line Editor #8565 created/updated

  • fixing bug with error not showing up in footer

  • fixing loading state thanks ashwinpc

  • trying to surface errors

  • adding new error for error state

  • Revert "fixing loading state thanks ashwinpc"

This reverts commit 64b5969.

  • correctly passing async search strat errors

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…opensearch-project#8565)

Backport PR:
opensearch-project#8565

From the original PR:

* initial commit for single line editor footer

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing styling and functionality

Signed-off-by: Sean Li <lnse@amazon.com>

* Changeset file for PR opensearch-project#8565 created/updated

* fixing bug with error not showing up in footer

Signed-off-by: Sean Li <lnse@amazon.com>

* fixing loading state thanks ashwinpc

Signed-off-by: Sean Li <lnse@amazon.com>

* trying to surface errors

Signed-off-by: Sean Li <lnse@amazon.com>

* adding new error for error state

Signed-off-by: Sean Li <lnse@amazon.com>

* Revert "fixing loading state thanks ashwinpc"

This reverts commit 64b5969.

* correctly passing async search strat errors

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
virajsanghvi
virajsanghvi previously approved these changes Oct 23, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (50a714f) to head (c267c3f).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ins/data/public/ui/query_editor/editors/shared.tsx 0.00% 21 Missing ⚠️
...ic/application/view_components/utils/use_search.ts 0.00% 5 Missing ⚠️
...query_string/language_service/lib/query_result.tsx 0.00% 2 Missing ⚠️
src/plugins/data/common/utils/helpers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8691      +/-   ##
==========================================
- Coverage   60.95%   60.93%   -0.02%     
==========================================
  Files        3792     3792              
  Lines       90464    90488      +24     
  Branches    14197    14202       +5     
==========================================
+ Hits        55140    55142       +2     
- Misses      31838    31861      +23     
+ Partials     3486     3485       -1     
Flag Coverage Δ
Linux_1 29.08% <0.00%> (-0.02%) ⬇️
Linux_2 56.53% <0.00%> (ø)
Linux_3 37.69% <0.00%> (-0.02%) ⬇️
Linux_4 29.96% <0.00%> (-0.02%) ⬇️
Windows_1 29.10% <0.00%> (-0.02%) ⬇️
Windows_2 56.49% <0.00%> (ø)
Windows_3 37.69% <0.00%> (-0.02%) ⬇️
Windows_4 29.96% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sejli
sejli previously approved these changes Oct 23, 2024
@virajsanghvi
Copy link
Collaborator

There is a snapshot test failure... Is this expected, @sejli?

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh dismissed stale reviews from sejli and virajsanghvi via c267c3f October 23, 2024 20:02
@ananzh ananzh merged commit 10f15e5 into opensearch-project:2.x Oct 23, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants