Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query Insghts] Memory budgeting for Query Insights services #13369

Open
ansjcy opened this issue Apr 24, 2024 · 1 comment
Open

[Query Insghts] Memory budgeting for Query Insights services #13369

ansjcy opened this issue Apr 24, 2024 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights

Comments

@ansjcy
Copy link
Member

ansjcy commented Apr 24, 2024

Is your feature request related to a problem? Please describe

As we add more query insights services like top n queries by different metrics types and top queries shapes, we are introducing higher memory usage to store all the metrics. We should provide the ability for the user to set memory budget for query insights features to avoid over-using memory on each node.

Describe the solution you'd like

We can provide separate, but generic configuration endpoints to set limits on memory usages for diffrent query inisght services. For example, for top n queries, we can provide something like:

 search.insights.top_queries.latency.max_memory_usage: "5mb",

to set the maximum memory that the top n queries by latency service can use to 5mb.

Related component

Search:Query Insights

Describe alternatives you've considered

We can also consider providing only one configuration endpoint to set limit on resource usage for all the query insights components. It would make the configuration easier but will also take away the customization for different query insights features. If one feature is using too much memory it would starve other query insights services.

Additional context

Please refer to the meta issue: #11522

@ansjcy ansjcy added enhancement Enhancement or improvement to existing feature or request untriaged labels Apr 24, 2024
@ansjcy ansjcy changed the title [Query insghts] Memory budgeting for Query Insights services [Query Insghts] Memory budgeting for Query Insights services Apr 24, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8]
@ansjcy Thanks for creating this issue. Please work with maintainers in the area to see that this approach will not introduce too much overhead for cluster administration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

2 participants