[Backport 2.x] Add new parameters to snapshot restore to rename the restored aliases… #16447
+506
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project#16292) * Add new parameters to snapshot restore to rename the restored aliases similar to the existing parameters to rename indexes Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Fix comment. Update changelog. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * New parameters needs to only used for new version Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add missing equals and hash implemenation for new parameters Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add some tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add some more tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Use CountDownLatch Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add two more tests. Refactoring and cleanup. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Use CURRENT version to pass backward compatibility tests. Change to V2.18 later once it is backported into that version. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Refactoring Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Overwriting aliases variable causes test failures for reasons I do not understand. Also some refactoring. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Convert to paramaterized tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> --------- Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16447 +/- ##
============================================
+ Coverage 71.77% 71.83% +0.05%
+ Complexity 65344 65335 -9
============================================
Files 5312 5312
Lines 304914 304968 +54
Branches 44425 44437 +12
============================================
+ Hits 218861 219059 +198
+ Misses 67803 67574 -229
- Partials 18250 18335 +85 ☔ View full report in Codecov by Sentry. |
saratvemulapalli
approved these changes
Oct 23, 2024
saratvemulapalli
merged commit c34bee4
into
opensearch-project:2.x
58 of 60 checks passed
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9489a21 from #16292