-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.9] Backport 2.x Adds chained alerts (#976) #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds chained alerts (#976) * chained alert triggers Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * converge all single node test cases Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add license headers to files Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow not found issue Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * added audit state alerts for doc level monitors Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add audit alerts in query level monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * temp: upload custom built common utils jar Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix get monitor response parsing to include associated_workflows Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add query level monitor audit alerts tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add audit alerts in bucket level monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * alerting Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * verify bucket monitor audit alerts and chained alerts in workflow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * make execution id mandatory Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert mapping update in run job method Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * minor fixes in chained alert trigger result Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained alert triggers tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix acknowledge chained alert bug Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert get alerts change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * refactor and remove transport actions being invoked in other transport actions Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add license header Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * scheduled job mapping schema Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix ktlint and revert gradle dev set up chanegs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix post delete method and refactor alert mover to add class level logger Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix test - pass workflow id in get alerts Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix check for workflow id is empty or null in get alerts action Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix alert mover method delegate monitor parsing logic Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove common utils jar from repo Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix imports Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit d2d03c6)
eirsep
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.9 #1008 +/- ##
============================================
- Coverage 75.30% 74.29% -1.02%
- Complexity 116 119 +3
============================================
Files 144 158 +14
Lines 8525 9460 +935
Branches 1225 1364 +139
============================================
+ Hits 6420 7028 +608
- Misses 1484 1735 +251
- Partials 621 697 +76
|
getsaurabh02
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d2d03c6 from #1007