Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integ test failures #1580

Merged

Conversation

riysaxen-amzn
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn commented Jun 19, 2024

Removed assertion from integ tests causing build failure in jenkins

https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/8329/pipeline/126

If the tests are running on a cluster that has more than just the alerting plugin installed on it, there might be indexes for those plugins created as well, the subsequent assertions are more important, so removed the assertion that checks how many indices exist

Test faIlures in jenkins integ test:

Suite: Test class org.opensearch.alerting.transport.GetRemoteIndexesActionIT

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with TRUE include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:273B758717CBD74]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with TRUE include_mappings param(GetRemoteIndexesActionIT.kt:205)

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with FALSE include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:5240C08E4E2190E6]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with FALSE include_mappings param(GetRemoteIndexesActionIT.kt:156)

  2> REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with blank include_mappings param" -Dtests.seed=C75572776830D42C -Dtests.security.manager=false -Dtests.locale=ro -Dtests.timezone=Pacific/Enderbury -Druntime.java=21

  2> java.lang.AssertionError: expected:<2> but was:<3>

        at __randomizedtesting.SeedInfo.seed([C75572776830D42C:21E8F236EC2DDBF]:0)

        at org.junit.Assert.fail(Assert.java:89)

        at org.junit.Assert.failNotEquals(Assert.java:835)

        at org.junit.Assert.assertEquals(Assert.java:120)

        at org.junit.Assert.assertEquals(Assert.java:146)

        at org.opensearch.alerting.transport.GetRemoteIndexesActionIT.test with blank include_mappings param(GetRemoteIndexesActionIT.kt:106)

  2> NOTE: leaving temporary files on disk at: /tmp/tmpk47m_ab0/alerting/alerting/build/testrun/integTest/temp/org.opensearch.alerting.transport.GetRemoteIndexesActionIT_C75572776830D42C-001

  2> NOTE: test params are: codec=Asserting(Lucene99): {}, docValues:{}, maxPointsInLeafNode=705, maxMBSortInHeap=5.417424553640299, sim=Asserting(RandomSimilarity(queryNorm=true): {}), locale=ro, timezone=Pacific/Enderbury

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
@riysaxen-amzn riysaxen-amzn merged commit 8801a63 into opensearch-project:main Jun 19, 2024
17 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
* fix integ test failures in jenkins infra

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix integ test failures in jenkins infra

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit 8801a63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
* fix integ test failures in jenkins infra

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix integ test failures in jenkins infra

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit 8801a63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jun 19, 2024
* fix integ test failures in jenkins infra



* fix integ test failures in jenkins infra



---------


(cherry picked from commit 8801a63)

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jun 19, 2024
* fix integ test failures in jenkins infra



* fix integ test failures in jenkins infra



---------


(cherry picked from commit 8801a63)

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants