[Backport 2.13] [Backport 2.x] Enable cross-cluster monitor cluster setting #1612 #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
AWSHurneyt
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Build is failing due to the following compiler error.
https://github.com/opensearch-project/alerting/actions/runs/10083295005/job/27933608106?pr=1618#step:5:58
e: file:///home/runner/work/alerting/alerting/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportGetAlertsAction.kt:97:45 Unresolved reference: boolQueryBuilder
> Task :alerting:compileKotlin FAILED
That import is missing because the alerting 2.13 branch is currently set to v2.13.0, and the v2.13.0 common utils artifact doesn't contain the following PR that introduced a boolQueryBuilder to the data model.
changes to add start_time and end_time filters to getalertsrequest (
Will bump the alerting version in a separate PR.
Approving as the tests pass in the initial PR #1612
riysaxen-amzn
approved these changes
Jul 25, 2024
AWSHurneyt
added a commit
that referenced
this pull request
Jul 30, 2024
AWSHurneyt
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f0ff930 from #1613.