Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.15] separate doc-level monitor query indices for externally defined monitors #1665

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport abdeca9 from #1664.

…ors (#1664)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit abdeca9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sbcd90 sbcd90 closed this Sep 26, 2024
@sbcd90 sbcd90 reopened this Sep 26, 2024
sbcd90 and others added 2 commits September 26, 2024 15:01
Signed-off-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@@ -59,7 +59,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
# This step uses the upload-artifact Github action: https://github.com/actions/upload-artifact
- name: Upload Artifacts
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbcd90 Are these changes intended to be in this PR?

@sbcd90
Copy link
Collaborator

sbcd90 commented Sep 30, 2024

@sbcd90 Are these changes intended to be in this PR?

yes. common-utils moved to 2.15.1. So, #1586 is needed.
build fails if upload-artifact is not moved to v3. So #1656 is needed.

@sbcd90 sbcd90 merged commit 9ef4873 into 2.15 Sep 30, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants