Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix alert constructor with noop trigger to use executi… #994

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jul 11, 2023

…on id and workflow id

Issue #, if available:

Description of changes:
backport of pr #981

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…on id and workflow id

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #994 (06fb662) into 2.x (c2250d5) will decrease coverage by 0.10%.
The diff coverage is 76.27%.

@@             Coverage Diff              @@
##                2.x     #994      +/-   ##
============================================
- Coverage     75.43%   75.33%   -0.10%     
  Complexity      116      116              
============================================
  Files           141      144       +3     
  Lines          8418     8519     +101     
  Branches       1203     1222      +19     
============================================
+ Hits           6350     6418      +68     
- Misses         1461     1486      +25     
- Partials        607      615       +8     
Impacted Files Coverage Δ
...in/kotlin/org/opensearch/alerting/MonitorRunner.kt 66.66% <ø> (ø)
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 75.29% <0.00%> (-0.40%) ⬇️
...org/opensearch/alerting/model/destination/Chime.kt 80.00% <ø> (ø)
...search/alerting/model/destination/CustomWebhook.kt 96.10% <ø> (ø)
...org/opensearch/alerting/model/destination/Slack.kt 80.00% <ø> (ø)
...rch/alerting/model/destination/email/EmailGroup.kt 90.12% <ø> (ø)
...erting/transport/TransportGetDestinationsAction.kt 86.30% <ø> (ø)
...h/alerting/transport/TransportGetFindingsAction.kt 89.18% <ø> (ø)
.../alerting/transport/TransportIndexMonitorAction.kt 56.34% <0.00%> (-3.43%) ⬇️
.../org/opensearch/alerting/util/AlertingException.kt 71.42% <ø> (ø)
... and 15 more

... and 4 files with indirect coverage changes

@sbcd90 sbcd90 merged commit 8567028 into opensearch-project:2.x Jul 11, 2023
13 of 16 checks passed
@sbcd90 sbcd90 added the backport 2.9 backports PRs to 2.9 label Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
…on id and workflow id (#994)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 8567028)
sbcd90 pushed a commit that referenced this pull request Jul 11, 2023
…on id and workflow id (#994) (#995)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.9 backports PRs to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants