Fix issues in running historical analysis and custom result index section #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
amitgalitz
reviewed
Oct 14, 2024
| const url = dataSourceId | ||
| ? `${baseUrl}/${dataSourceId}/start` | ||
| : `${baseUrl}/start`; | ||
| const baseUrl = `${AD_NODE_API.DETECTOR}/${detectorId}/start`; |
There was a problem hiding this comment.
should we have _start instead of start? or both can be used?
ref: https://opensearch.org/docs/latest/observing-your-data/ad/api/#start-detector-job
There was a problem hiding this comment.
we have to use start here. It's different from the _start in the doc you pasted
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
|
e2e CI failed for this error, not related to this pr: Did manual e2e verification |
amitgalitz
approved these changes
Oct 14, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-889-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 646a08ec2656df5b0597f454fcf4b95f21b513cc
# Push it to GitHub
git push --set-upstream origin backport/backport-889-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17Then, create a pull request where the |
amitgalitz
pushed a commit
that referenced
this pull request
Oct 14, 2024
…tion (#889) (#892) * Fix issues in running historical analysis and custom result index Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update snapshot Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 646a08e) Co-authored-by: Jackie Han <jkhanjob@gmail.com>
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the following issues:
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.