Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in running historical analysis and custom result index section #889

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix issues in running historical analysis and custom result index section #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
648a506
Fix issues in running historical analysis and custom result index
jackiehanyang Oct 14, 2024
d0a2d84
update snapshot
jackiehanyang Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/pages/DefineDetector/components/CustomResultIndex/CustomResultIndex.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function CustomResultIndex(props: CustomResultIndexProps) {
disabled={props.isEdit}
onChange={() => {
if (enabled) {
form.setFieldValue('resultIndex', '');
form.setFieldValue('resultIndex', undefined);
}
setEnabled(!enabled);
}}
Expand Down
6 changes: 3 additions & 3 deletions public/pages/DefineDetector/containers/__tests__/__snapshots__/DefineDetector.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1603,7 +1603,7 @@ exports[`<DefineDetector /> empty creating detector definition renders the compo
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M7.999 15.999a8 8 0 1 1 0-16 8 8 0 0 1 0 16ZM8 15A7 7 0 1 0 8 1a7 7 0 0 0 0 14ZM3.5 5h9a.5.5 0 1 1 0 1h-9a.5.5 0 0 1 0-1Zm2 3h5a.5.5 0 1 1 0 1h-5a.5.5 0 0 1 0-1Zm2 3h1a.5.5 0 1 1 0 1h-1a.5.5 0 1 1 0-1Z"
d="m9.759 12.652-1.8 2.25-.78-.625 1.8-2.25A.1.1 0 0 0 9 11.965V8.362a1 1 0 0 1 .232-.64l4.631-5.558A.1.1 0 0 0 13.787 2H2.213a.1.1 0 0 0-.077.164l4.631 5.558a1 1 0 0 1 .232.64v5.853a.1.1 0 0 0 .178.062l.781.625c-.65.812-1.959.353-1.959-.687V8.362L1.368 2.804C.771 2.088 1.281 1 2.214 1h11.573c.932 0 1.442 1.088.845 1.804L10 8.362v3.603a1.1 1.1 0 0 1-.241.687Z"
fill-rule="evenodd"
/>
</svg>
Expand Down Expand Up @@ -2699,7 +2699,7 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M7.999 15.999a8 8 0 1 1 0-16 8 8 0 0 1 0 16ZM8 15A7 7 0 1 0 8 1a7 7 0 0 0 0 14ZM3.5 5h9a.5.5 0 1 1 0 1h-9a.5.5 0 0 1 0-1Zm2 3h5a.5.5 0 1 1 0 1h-5a.5.5 0 0 1 0-1Zm2 3h1a.5.5 0 1 1 0 1h-1a.5.5 0 1 1 0-1Z"
d="m9.759 12.652-1.8 2.25-.78-.625 1.8-2.25A.1.1 0 0 0 9 11.965V8.362a1 1 0 0 1 .232-.64l4.631-5.558A.1.1 0 0 0 13.787 2H2.213a.1.1 0 0 0-.077.164l4.631 5.558a1 1 0 0 1 .232.64v5.853a.1.1 0 0 0 .178.062l.781.625c-.65.812-1.959.353-1.959-.687V8.362L1.368 2.804C.771 2.088 1.281 1 2.214 1h11.573c.932 0 1.442 1.088.845 1.804L10 8.362v3.603a1.1 1.1 0 0 1-.241.687Z"
fill-rule="evenodd"
/>
</svg>
Expand Down Expand Up @@ -3288,4 +3288,4 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon
</div>
</div>
</div>
`;
`;
6 changes: 2 additions & 4 deletions public/redux/reducers/ad.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,8 @@ export const startHistoricalDetector = (
startTime: number,
endTime: number
): APIAction => {
const baseUrl = `${AD_NODE_API.DETECTOR}/${detectorId}`;
const url = dataSourceId
? `${baseUrl}/${dataSourceId}/start`
: `${baseUrl}/start`;
const baseUrl = `${AD_NODE_API.DETECTOR}/${detectorId}/start`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have _start instead of start? or both can be used?
ref: https://opensearch.org/docs/latest/observing-your-data/ad/api/#start-detector-job

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to use start here. It's different from the _start in the doc you pasted

const url = dataSourceId ? `${baseUrl}/${dataSourceId}` : baseUrl;

return {
type: START_HISTORICAL_DETECTOR,
Expand Down
Loading