Update BWC Test Version and Enhance Code Coverage #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
infra
This PR updates the BWC test version to 2.16 in the build.gradle file and includes additional integration and unit tests to improve code coverage. Testing Performed: * Executed gradle build to ensure successful build and integration. Signed-off-by: Kaituo Li <kaituo@amazon.com>
|
Not sure why WhiteSource Security Check failed. It shows it is scanning but never finishes. Will leave it as it is. |
amitgalitz
reviewed
Jun 24, 2024
build-tools/coverage.gradle
Outdated
| } | ||
|
|
||
| /** | ||
| * This code sets up coverage reporting manually for the k-NN plugin tests. This is complicated because: |
There was a problem hiding this comment.
nit: change to AD plugin tests
amitgalitz
reviewed
Jun 24, 2024
| @@ -27,7 +27,8 @@ public class ForecastEnabledSetting extends DynamicNumericSetting { | |||
| */ | |||
| public static final String FORECAST_ENABLED = "plugins.forecast.enabled"; | |||
|
|
|||
| public static final boolean enabled = false; | |||
| // TODO: remove the field when releasing forecasting | |||
| public static boolean enabled = false; | |||
There was a problem hiding this comment.
it is not being used. Removed.
Signed-off-by: Kaituo Li <kaituo@amazon.com>
amitgalitz
approved these changes
Jun 24, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1253-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08f23fa938812d9e2c9d28e4a5ee8d04ea8d5861
# Push it to GitHub
git push --set-upstream origin backport/backport-1253-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.xThen, create a pull request where the |
kaituo
added a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Jun 26, 2024
…#1253) * Update BWC Test Version and Enhance Code Coverage This PR updates the BWC test version to 2.16 in the build.gradle file and includes additional integration and unit tests to improve code coverage. Testing Performed: * Executed gradle build to ensure successful build and integration. Signed-off-by: Kaituo Li <kaituo@amazon.com> * address comments Signed-off-by: Kaituo Li <kaituo@amazon.com> --------- Signed-off-by: Kaituo Li <kaituo@amazon.com>
kaituo
added a commit
that referenced
this pull request
Jun 26, 2024
* Update BWC Test Version and Enhance Code Coverage This PR updates the BWC test version to 2.16 in the build.gradle file and includes additional integration and unit tests to improve code coverage. Testing Performed: * Executed gradle build to ensure successful build and integration. * address comments --------- Signed-off-by: Kaituo Li <kaituo@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Testing Performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.