Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #162

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 8, 2024

Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.

@reta
Copy link
Collaborator

reta commented Jul 9, 2024

The GA checks should be fixed by #163

@dblock
Copy link
Member Author

dblock commented Jul 11, 2024

Can we merge this pls? I'm not a maintainer here.

@reta
Copy link
Collaborator

reta commented Jul 11, 2024

Can we merge this pls? I'm not a maintainer here.

@dblock could you rebase please? so we could get green checks, thank you

…cklist.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the update-pull-request-template branch from d61ae8a to 0478a76 Compare August 1, 2024 18:06
@dblock dblock requested a review from reta August 1, 2024 18:06
@reta reta merged commit 9a7b217 into opensearch-project:main Aug 1, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2024
…cklist. (#162)

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 9a7b217)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Aug 1, 2024
…cklist. (#162) (#178)

(cherry picked from commit 9a7b217)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock dblock deleted the update-pull-request-template branch August 12, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants