From 279ab0f24ad838f680d526358c92fb7ef81712dd Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Wed, 11 Oct 2023 16:00:58 -0700 Subject: [PATCH] Remove integrations card from datasources (#1110) (#1118) * Remove integrations card * Fix test * Also include copy changes --------- (cherry picked from commit 48b1bad100d86612f82004d3cae48267e879c7b8) Signed-off-by: Derek Ho Signed-off-by: github-actions[bot] Co-authored-by: github-actions[bot] --- .../data_connection.test.tsx.snap | 45 ------------------- .../components/manage/data_connection.tsx | 8 ---- .../new/configure_s3_datasource.tsx | 20 ++++----- .../new/new_datasource_card_view.tsx | 2 +- 4 files changed, 11 insertions(+), 64 deletions(-) diff --git a/public/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap b/public/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap index bb7b39ed6..da46504aa 100644 --- a/public/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap +++ b/public/components/datasources/components/__tests__/__snapshots__/data_connection.test.tsx.snap @@ -656,51 +656,6 @@ exports[`Data Connection Page test Renders S3 data connection page with data 1`] -
-
-
- -
-
- - - -
-

- Explore data faster through integrations -

-
-
-
-
diff --git a/public/components/datasources/components/manage/data_connection.tsx b/public/components/datasources/components/manage/data_connection.tsx index 4c9da43a3..12b40df10 100644 --- a/public/components/datasources/components/manage/data_connection.tsx +++ b/public/components/datasources/components/manage/data_connection.tsx @@ -98,14 +98,6 @@ export const DataConnection = (props: any) => { } /> - - } - title={'Integrate data'} - description="Explore data faster through integrations" - onClick={() => application!.navigateToApp(observabilityIntegrationsID)} - /> - ); }; diff --git a/public/components/datasources/components/new/configure_s3_datasource.tsx b/public/components/datasources/components/new/configure_s3_datasource.tsx index 344252d4a..1b65c7b2b 100644 --- a/public/components/datasources/components/new/configure_s3_datasource.tsx +++ b/public/components/datasources/components/new/configure_s3_datasource.tsx @@ -88,7 +88,7 @@ export const ConfigureS3Datasource = (props: ConfigureS3DatasourceProps) => { - {`Connect to Amazon S3 via AWS Glue with Amazon EMR as an execution engine. `} + {`Connect to Amazon S3 via AWS Glue Data Catalog with Amazon EMR as an execution engine. `} Learn more @@ -96,7 +96,7 @@ export const ConfigureS3Datasource = (props: ConfigureS3DatasourceProps) => { - {`Connect to Amazon S3 via AWS Glue with Amazon EMR as an execution engine. `} + {`Connect to Amazon S3 via AWS Glue Data Catalog with Amazon EMR as an execution engine. `} Learn more @@ -129,7 +129,7 @@ export const ConfigureS3Datasource = (props: ConfigureS3DatasourceProps) => { -

AWS Glue authentication details

+

AWS Glue Data Catalog authentication details

@@ -138,14 +138,14 @@ export const ConfigureS3Datasource = (props: ConfigureS3DatasourceProps) => {

This parameter provides the authentication type information required for execution - engine to connect to AWS Glue. + engine to connect to AWS Glue Data Catalog.

- + <>

This should be the IAM role ARN

@@ -167,16 +167,16 @@ export const ConfigureS3Datasource = (props: ConfigureS3DatasourceProps) => { -

AWS Glue index store details

+

AWS Glue Data Catalog index store details

- + <>

- This parameter provides the OpenSearch cluster host information for AWS Glue. This - OpenSearch instance is used for writing index data back. + This parameter provides the OpenSearch cluster host information for AWS Glue Data + Catalog. This OpenSearch instance is used for writing index data back.

{
- + <>

Authentication settings to access the index store.

diff --git a/public/components/datasources/components/new/new_datasource_card_view.tsx b/public/components/datasources/components/new/new_datasource_card_view.tsx index bfc83ea85..bbd695bfb 100644 --- a/public/components/datasources/components/new/new_datasource_card_view.tsx +++ b/public/components/datasources/components/new/new_datasource_card_view.tsx @@ -23,7 +23,7 @@ export function NewDatasourceCardView() { { name: 'S3GLUE', displayName: 'S3', - description: 'Connect to Amazon S3 via AWS Glue', + description: 'Connect to Amazon S3 via AWS Glue Data Catalog', displayIcon: , onClick: () => (window.location.hash = `#/configure/S3GLUE`), },