Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Integrations Dynamic Catalogs: JsonCatalogDataAdaptor #1243

Closed
Swiddis opened this issue Nov 13, 2023 · 0 comments · Fixed by #1288
Closed

[FEATURE] Integrations Dynamic Catalogs: JsonCatalogDataAdaptor #1243

Swiddis opened this issue Nov 13, 2023 · 0 comments · Fixed by #1288
Assignees
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project

Comments

@Swiddis
Copy link
Collaborator

Swiddis commented Nov 13, 2023

Is your feature request related to a problem?
While we've had CatalogDataAdaptors since 2.10, we only ever use it for reading directly from the local file system, which makes it impossible to upload integrations dynamically and difficult for outside contributors to develop integrations.

What solution would you like?
As part of ongoing efforts to support this dynamic upload user story, one step is adding a JsonCatalogDataAdaptor. This would define a flat file format which can be used to upload integrations with minimal implementation complexity, and lay the groundwork for later being able to read integrations from an index. It also would make more thorough testing of integrations possible by enabling easier mock.

What alternatives have you considered?
A ZipCatalogDataAdaptor was experimented with in a prototype, since it's easier for a user to zip an integration directly. This is more complex than a Json adaptor to implement, particularly because we need to serialize to a temporary file to get the data (there's an open issue in the Zip library we use to remove this constraint), and deserializing Zip generally brings more security considerations than Json. It will be explored more at a later date.

Do you have any additional context?
Some groundwork for Dynamic Catalogs was done with #1236. A larger meta-issue to bundle all this will be published eventually.

@Swiddis Swiddis added enhancement New feature or request untriaged integrations Used to denote items related to the Integrations project labels Nov 13, 2023
@Swiddis Swiddis self-assigned this Nov 13, 2023
@Swiddis Swiddis removed the untriaged label Nov 13, 2023
@Swiddis Swiddis moved this to Todo in Observability 2023 Dec 5, 2023
@Swiddis Swiddis moved this from Todo to In Progress in Observability 2023 Dec 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Observability 2023 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant