Reverting notebooks changes, add docs/validation to datasources, explorer minor fixes #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 44.09% 44.23% +0.13%
==========================================
Files 325 327 +2
Lines 19378 19478 +100
Branches 4617 4643 +26
==========================================
+ Hits 8545 8616 +71
- Misses 10788 10817 +29
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Derek Ho <dxho@amazon.com>
…roject#985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
…lity into validation
derek-ho
changed the title
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
ps48
changed the title
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
pjfitzgibbons
approved these changes
Oct 9, 2023
ps48
approved these changes
Oct 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
…orer minor fixes (#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from #974 & #985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 4a8b500) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
…orer minor fixes (#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from #974 & #985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 4a8b500) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
added a commit
that referenced
this pull request
Oct 9, 2023
…orer minor fixes (#1101) (#1103) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from #974 & #985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>
ps48
added a commit
that referenced
this pull request
Oct 9, 2023
…orer minor fixes (#1101) (#1102) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from #974 & #985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 15, 2023
…orer minor fixes (opensearch-project#1101) * Add documentation linking and validation for query permissions Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with link Signed-off-by: Derek Ho <dxho@amazon.com> * Add form validation for name field Signed-off-by: Derek Ho <dxho@amazon.com> * reverting notebook changes from opensearch-project#974 & opensearch-project#985 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * surrounding events functionally working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small surrounding flyout ui changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…orer minor fixes (opensearch-project#1101) (opensearch-project#1102) * Add documentation linking and validation for query permissions * Update test with link * Add form validation for name field * reverting notebook changes from opensearch-project#974 & opensearch-project#985 * Remove console log * surrounding events functionally working * small surrounding flyout ui changes --------- (cherry picked from commit 4a8b500) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 2d4afc3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.