Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integrations card from datasources #1110

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 11, 2023

Description

Remove integrations card from datasources

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1110 (f3c72e0) into main (68d88f3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   44.20%   44.20%           
=======================================
  Files         327      327           
  Lines       19485    19484    -1     
  Branches     4642     4642           
=======================================
  Hits         8613     8613           
+ Misses      10827    10826    -1     
  Partials       45       45           
Flag Coverage Δ
dashboards-observability 44.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Signed-off-by: Derek Ho <dxho@amazon.com>
…vability into remove-integrations

Signed-off-by: Derek Ho <dxho@amazon.com>
@ps48 ps48 merged commit 48b1bad into opensearch-project:main Oct 11, 2023
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
* Remove integrations card

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix test

Signed-off-by: Derek Ho <dxho@amazon.com>

* Also include copy changes

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 48b1bad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
* Remove integrations card

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix test

Signed-off-by: Derek Ho <dxho@amazon.com>

* Also include copy changes

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 48b1bad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 11, 2023
* Remove integrations card



* Fix test



* Also include copy changes



---------


(cherry picked from commit 48b1bad)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 11, 2023
* Remove integrations card



* Fix test



* Also include copy changes



---------


(cherry picked from commit 48b1bad)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Oct 15, 2023
* Remove integrations card

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix test

Signed-off-by: Derek Ho <dxho@amazon.com>

* Also include copy changes

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Oct 30, 2023
…esh button is hit, the app breaks. (opensearch-project#1110)

* fix for blank stats query breaking the app

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Eliminated isRefresh from fetchData

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* fixed blank stats issue for gauge

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Removed span initialization for config

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…pensearch-project#1191)

Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>

Co-authored-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
Co-authored-by: anijain-Amazon <110471048+anijain-Amazon@users.noreply.github.com>
Co-authored-by: Deepak Devarakonda <devardee@amazon.com>
Co-authored-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit eee08a5f1d91850c741a0085ea5f2beccaf0c343)
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1117)

* Remove integrations card

* Fix test

* Also include copy changes

---------

(cherry picked from commit 48b1bad)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3ed626e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants