Add S3 Integrations for Apache and S3 Access #1218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
- Coverage 44.07% 44.06% -0.02%
==========================================
Files 329 329
Lines 19668 19682 +14
Branches 4735 4685 -50
==========================================
+ Hits 8669 8673 +4
- Misses 10422 10964 +542
+ Partials 577 45 -532
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
changed the title
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…earch-project#1218) Added a retry around the the bootstrap that previously failed due to network issues. Ran the new version of this workflow 100 iterations on linux and windows, both passed at 100% [1]. Without the retry during a run of 100 iterations [2], the windows test failed once during the bootstrap. If we see future issues, we could attempt to add retries to them following this same pattern. [1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073 [2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181 Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 3abb70774c42feecf9aa8202f959530be05bc2a3) Co-authored-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing the content additions, here's a WIP S3 integration for Apache. Still has a lot of failing panels, more work needed to get them in order.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.