-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]Revise and edit PPL in-product documentation #1233
[DOC]Revise and edit PPL in-product documentation #1233
Conversation
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
===========================================
+ Coverage 44.06% 56.32% +12.26%
===========================================
Files 329 327 -2
Lines 19672 11944 -7728
Branches 4685 2741 -1944
===========================================
- Hits 8669 6728 -1941
+ Misses 10958 5171 -5787
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@anirudha I've rewritten the PPL reference manual (in-product) documentation. The old version has several writing and tech inaccuracies. This revised version has gone through tech and editorial review is ready to be published. Who can I work with to get this published? Also, we need to change the page on which the manual opens. It currently opens to the cc: @hdhalter |
@anirudha @joshuali925 @hdhalter Is this PR ready to be merged? The content was rewritten, especially for clarity, grammar, and relevancy. It's gone through tech review, doc review, and editorial review. What are the next steps to update the UI changes and publish content to Dashboards? The following UI updates are needed:
|
Thanks for making the UI changes :) |
@anirudha @joshuali925 Whats the next step here? Can we target this for 2.12.0 release? What are the next steps to update the UI changes and publish content to Dashboards? |
Signed-off-by: Melissa Vagi <vagimeli@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 31b0a94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 31b0a94) Signed-off-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
…#1233) Signed-off-by: Melissa Vagi <vagimeli@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
…#1233) (opensearch-project#1368) (cherry picked from commit 31b0a94) Signed-off-by: Melissa Vagi <vagimeli@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 65f8eaa)
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 57db4dc)
Description
Revises PPL in-produce for clarity and edits grammatical, spelling, and other writing errors.
UX note: The manual opens to the
where
command section. Update to open to theOverview
section. See the following image for reference.Issues Resolved
opensearch-project/documentation-website#1152
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.