Refactor repository reading for recursive directory searching #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 44.06% 44.08% +0.01%
==========================================
Files 329 329
Lines 19672 19682 +10
Branches 4685 4687 +2
==========================================
+ Hits 8669 8677 +8
- Misses 10958 10960 +2
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. |
Swiddis
added
integrations
YANG-DB
approved these changes
Nov 13, 2023
|
Does this need backport to 2.x? |
ps48
approved these changes
Nov 13, 2023
Yes, but I think we're planning on changing the branching strategy to avoid needing as many backports for our next releases. I'll hold off on backporting until after that discussion has developed further. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
(cherry picked from commit d7efbd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some refactoring of the repository class to better handle recursive directories and make its role more flexible. There are still some updates needed to add searching a local recursive repository (mostly regarding locating specific integrations), but that will be enabled when catalog metadata is added.
Issues Resolved
Resolves #1236
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.