Added HAProxy Integration #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com>
Pothula-Kalyani-ML
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
=======================================
Coverage 44.06% 44.06%
=======================================
Files 329 329
Lines 19682 19682
Branches 4685 4685
=======================================
+ Hits 8672 8673 +1
+ Misses 10965 10964 -1
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks for the contribution, and especially for including a docker-compose file. It helps a ton with reviewing faster. There are still a few questions I have about getting it set up, I think the bulk of the issue is just that this is built off of an old test compose that needs a couple updates to accommodate the new setup.
server/adaptors/integrations/__data__/repository/haproxy/info/test/.gitignore
Outdated
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/haproxy/info/test/docker-compose.yaml
Outdated
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/haproxy/info/test/docker-compose.yaml
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/haproxy/info/test/fluent-bit/fluent-bit.conf
Outdated
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/haproxy/info/test/docker-compose.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com>
Swiddis
reviewed
Nov 27, 2023
...er/adaptors/integrations/__data__/repository/haproxy/info/test/fluent-bit/otel-converter.lua
Outdated
Show resolved
Hide resolved
Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com>
YANG-DB
approved these changes
Nov 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Added HAProxy Integration Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com> * Updated test directory for HAProxy integration Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com> * updated docker-compose.yaml and otel-converter.lua Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com> --------- Signed-off-by: Pothula-Kalyani-ML <pothula.kalyani@maplelabs.com> (cherry picked from commit f1237c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new observability integration for HAProxy
Issues Resolved
Ability to monitor HAProxy Access Logs
Check List
Results
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.