[Backport 2.x] Refactor Cypress workflow #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1299 +/- ##
========================================
Coverage 56.42% 56.42%
========================================
Files 327 327
Lines 11930 11930
Branches 2799 2740 -59
========================================
Hits 6732 6732
- Misses 4895 5153 +258
+ Partials 303 45 -258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
|
Hi team, I made some changes in this PR and I will forwardport it into
Btw one more thing I observed is that, the cc: @ps48, @mengweieric, @Swiddis |
RyanL1997
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Dec 14, 2023
Signed-off-by: Ryan Liang <jiallian@amazon.com>
ps48
approved these changes
Dec 15, 2023
6 tasks
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…ect#1299) Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit bea778f73b76cb5bd4e17d25f994409590c4fac9)
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* [CI/CD] Refactor Cypress workflow Signed-off-by: Ryan Liang <jiallian@amazon.com> * Remove duplicate group Signed-off-by: Ryan Liang <jiallian@amazon.com> * Enable cypress workflow Signed-off-by: Ryan Liang <jiallian@amazon.com> * Rename the title of each job Signed-off-by: Ryan Liang <jiallian@amazon.com> * Correct the path to event analytics test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 11ecfa6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
integrations.spec.js.mainIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.