-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport main - Metrics Explorer updated with PromQL (#1303) #1305
Conversation
* Metrics Explorer updated with PromQL including query for Prometheus Metrics and updated Export Panel Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
958186a
to
de680cf
Compare
@@ -1,7 +1,7 @@ | |||
// Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|||
exports[`Trace Config component renders empty trace config 1`] = ` | |||
<TraceConfig | |||
<Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests are failing here cause, the OSD is not on main branch.
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
b76e426
to
c610945
Compare
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
public/components/metrics/top_menu/__tests__/metrics_export.test.tsx
Outdated
Show resolved
Hide resolved
I see now with snapshot updates all tests pass except one from metrics, due to missing package.
|
…ration testing. Correct a snapshot. Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
+ Coverage 56.32% 57.42% +1.09%
==========================================
Files 327 330 +3
Lines 11944 12091 +147
Branches 2741 2792 +51
==========================================
+ Hits 6728 6943 +215
+ Misses 5171 5102 -69
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Reverted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the linting errors for now, as linter is not backported to 2.x and this PR is already merged in 2.x
including query for Prometheus Metrics and updated Export Panel
Signed-off-by: Peter Fitzgibbons peter.fitzgibbons@gmail.com
(cherry picked from commit d16f2b2)
Signed-off-by: Peter Fitzgibbons peter.fitzgibbons@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.