Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default timestamp field #1329

Closed

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Dec 27, 2023

Description

We are integrating ppl_visualization in Notebook page and found that if the timestamp field of a ppl metadata is empty string, the ppl_visualization is unable to launch and render in Notebook page, but is able to render in visualization detail page.

Before:

Unable to render in Notebook page:
image

able to render in visualization page:
image

After

Able to render in Notebook page:
image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cdbcfa4) 51.57% compared to head (b511e16) 51.56%.

Files Patch % Lines
public/components/custom_panels/helpers/utils.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   51.57%   51.56%   -0.01%     
==========================================
  Files         305      305              
  Lines       10651    10652       +1     
  Branches     2793     2794       +1     
==========================================
  Hits         5493     5493              
- Misses       5112     5113       +1     
  Partials       46       46              
Flag Coverage Δ
dashboards-observability 51.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant