Add Flint queries for Apache Access integration #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Swiddis
added
enhancement
YANG-DB
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Can you please update according with the next list guidelines
opensearch-project/opensearch-catalog#144
server/adaptors/integrations/__data__/repository/apache/assets/create_table-1.0.0.sql
Show resolved
Hide resolved
Can you make this feedback more actionable? That's a large RFC and I'm not certain which parts I'm meant to apply right now. |
|
Hi |
|
Commented on the RFC, I don't think these changes are applicable to 2.13, and are at least out of scope for this PR. |
YANG-DB
approved these changes
Apr 11, 2024
YANG-DB
approved these changes
Apr 15, 2024
ps48
approved these changes
Apr 15, 2024
paulstn
approved these changes
Apr 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Add nginx integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add VPC S3 integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic apache integration based on nginx Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add initial S3 integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply keyword changes to s3 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove old S3 attempt Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Adapt apache query loading to new config format Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove old aws s3 attempt (again) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit bbcd3c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
added a commit
that referenced
this pull request
Apr 15, 2024
* Add nginx integration * Add VPC S3 integration * Add basic apache integration based on nginx * Add initial S3 integration * Apply keyword changes to s3 * Remove old S3 attempt * Adapt apache query loading to new config format * Remove old aws s3 attempt (again) --------- (cherry picked from commit bbcd3c1) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: YANGDB <yang.db.dev@gmail.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
) * Add nginx integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add VPC S3 integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic apache integration based on nginx Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add initial S3 integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply keyword changes to s3 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove old S3 attempt Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Adapt apache query loading to new config format Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove old aws s3 attempt (again) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit bbcd3c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some queries with simple mappings. Future work needed for more complicated fields (like user agent parsing).
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.