Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Editor for Metrics Visualizations. #940

Closed
wants to merge 3 commits into from

Conversation

pjfitzgibbons
Copy link
Contributor

@pjfitzgibbons pjfitzgibbons commented Aug 16, 2023

Description

  • Add Inline Editor to all Prometheus-connected Metrics in Metrics Explorer
    image

  • Ensure Prometheus-connected Metric is displayed correctly on Observability Dashboards
    image

  • Ensure Prometheus-connected Metric - Saved As Visualization - Is editable in Log Explorer / Visualization
    image

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

common/utils/query_utils.ts Outdated Show resolved Hide resolved
common/utils/query_utils.ts Outdated Show resolved Hide resolved
common/utils/query_utils.ts Outdated Show resolved Hide resolved
common/utils/query_utils.ts Outdated Show resolved Hide resolved
public/components/custom_panels/helpers/utils.tsx Outdated Show resolved Hide resolved
public/components/metrics/top_menu/top_menu.tsx Outdated Show resolved Hide resolved
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
@pjfitzgibbons pjfitzgibbons force-pushed the feature/metrics-editor-and-promql branch from b0cf917 to 01b6bab Compare September 26, 2023 21:18
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
@pjfitzgibbons pjfitzgibbons deleted the feature/metrics-editor-and-promql branch November 9, 2023 23:34
JulianQuispel pushed a commit to JulianQuispel/dashboards-observability that referenced this pull request Jan 24, 2024
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants