-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline Editor for Metrics Visualizations. #940
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavithacm
reviewed
Aug 16, 2023
pjfitzgibbons
force-pushed
the
feature/metrics-editor-and-promql
branch
from
August 22, 2023 18:48
1d5c1e2
to
e142238
Compare
pjfitzgibbons
requested review from
ps48,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
September 7, 2023 20:41
pjfitzgibbons
commented
Sep 7, 2023
joshuali925
reviewed
Sep 7, 2023
public/components/notebooks/components/paragraph_components/para_output.tsx
Outdated
Show resolved
Hide resolved
YANG-DB
approved these changes
Sep 7, 2023
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
pjfitzgibbons
force-pushed
the
feature/metrics-editor-and-promql
branch
from
September 26, 2023 21:18
b0cf917
to
01b6bab
Compare
14 tasks
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
JulianQuispel
pushed a commit
to JulianQuispel/dashboards-observability
that referenced
this pull request
Jan 24, 2024
Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Inline Editor to all Prometheus-connected Metrics in Metrics Explorer
Ensure Prometheus-connected Metric is displayed correctly on Observability Dashboards
Ensure Prometheus-connected Metric - Saved As Visualization - Is editable in Log Explorer / Visualization
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.