Define tables #126

sumukhswamy · 2023-09-21T06:25:24Z

Description

added changes for flint
sidebar changes with create and Data-connections tab added
added tables names as indexed

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

public/components/Main/main.tsx

public/components/app.tsx

public/components/Main/main.tsx

derek-ho · 2023-09-21T14:08:38Z

public/components/Main/main.tsx

+      const schema: object[] = _.get(responseObj, 'schema');
+      const datarows: any[][] = _.get(responseObj, 'datarows');
+      fields = datarows.map((data)=>{
+      return data[2]


Why the third element?

the way datarows extracts the object is like this

public/components/Main/main.tsx

public/components/SQLPage/TableView.tsx

public/components/Main/main.tsx

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

public/components/SQLPage/TableView.tsx

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

codecov · 2023-09-27T19:03:30Z

Codecov Report

Merging #126 (ccfa0f5) into main (69a91fb) will decrease coverage by 17.54%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #126       +/-   ##
===========================================
- Coverage   62.76%   45.23%   -17.54%     
===========================================
  Files          10       29       +19     
  Lines         658     1017      +359     
  Branches      119      155       +36     
===========================================
+ Hits          413      460       +47     
- Misses        192      502      +310     
- Partials       53       55        +2

Flag	Coverage Δ
dashboards-query-workbench	`45.23% <ø> (-17.54%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

ps48 · 2023-09-28T17:47:11Z

@sumukhswamy Can you please sign these commits and update the failing tests?

Error: The SoB (DCO) check failed

  7b9038fc00b292fdb009d9e17281c44f2e56e4ec    The sign-off is missing.
  3c337cad7184b7c95531514c1b335f84ab1c22f2    The sign-off is missing.
  c2d241d21964cf729ee6f20053916e469541dc32    The sign-off is missing.

public/components/Main/main.test.tsx

derek-ho · 2023-09-28T20:11:58Z

public/components/Main/main.test.tsx

@@ -61,7 +71,7 @@ describe("<Main /> spec", () => {
    const client = httpClientMock;
    client.post = jest.fn().mockRejectedValue('err');

-    const { getByText } = render(
+    const { getByText } = await render(


is the await necessary here?

since the component now has the sidebar which has http calls for setting the parameters

derek-ho · 2023-09-28T20:13:29Z

public/components/Main/main.tsx

+            <EuiComboBox
+              placeholder='Connection Name'
+              options={[
+                { label: 'S3', value: 'S3' },
+                { label: 'Opensearch', value: 'Opensearch' },
+              ]}
+              selectedOptions={this.state.selectedDatasource ? [{ label: this.state.selectedDatasource }] : []}
+              onChange={(selectedOptions) => {
+                const selectedValue = selectedOptions[0] ? selectedOptions[0].value : '';


I thought we were changing this to single select?

I think even super select may make more sense here

this is just a placeholder will be using Eric code for data selector

public/components/Main/main.tsx

common/constants.ts

public/components/Main/main.test.tsx

public/components/Main/main.tsx

joshuali925 · 2023-09-28T20:14:44Z

public/components/Main/main.tsx

+              selectedOptions={this.state.selectedDatasource ? [{ label: this.state.selectedDatasource }] : []}
+              onChange={(selectedOptions) => {
+                const selectedValue = selectedOptions[0] ? selectedOptions[0].value : '';
+                this.handleComboOptionChange(selectedValue);


what happens when user selects multiple? should combo box set single selection?

this is just a placeholder will be using Eric code for data selector

joshuali925 · 2023-09-28T20:15:28Z

public/components/SQLPage/TableView.tsx

+                setTablenames(fields)
+            })
+            .catch((err) => {
+                console.error(err);


should user be notified?

if there is an error in the query, will there be a visual indication besides the console message?

this is for the side bar, so here will be no visual indication, this is to list the datasources he has available

also for #126 (comment) i have made the changes and spoken to Derek about it

this is for the side bar, so here will be no visual indication, this is to list the datasources he has available

do we expect this to fail often? my concern is for example user accidentally deleted sql plugin, and workbench can't get the list of datasources but user doesn't know why

oh okay , will add cod to show error if it occurs

have added an error message for handling missing data

derek-ho

Blocking this PR on this comment: #126 (comment)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

joshuali925 · 2023-09-29T19:54:22Z

could you answer this? #126 (comment)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

joshuali925 · 2023-09-29T22:04:27Z

non blocking: could you set up prettier? the formattings are off with 4 spaces indentation and OSD sets it to 2. we had this issue before, it would introduce unnecessary diffs in other PRs

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* added changes for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added side bar with tables indexed Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added dynamic element for tree view, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * made a few design and panel changes, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the constants file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for search bar removal, pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * readded console.log Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated test suites, removed search field Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for Data connection and combo box Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock for http query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock template name in tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed more comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added error message for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* Add table acceleration flyout (#128) * Add table acceleration flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * comment on hardcoded elements Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * additional comment on hardcoded Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * review fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert version changes, inline type declare Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Increment version to 3.0.0.0 (#121) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add materialized view visual builder and query builders (#129) * add materialized view visual builder and query builders Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * organize header and PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Define tables (#126) * added changes for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added side bar with tables indexed Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added dynamic element for tree view, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * made a few design and panel changes, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the constants file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for search bar removal, pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * readded console.log Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated test suites, removed search field Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for Data connection and combo box Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock for http query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock template name in tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed more comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added error message for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * update packages and tsconfig (#130) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update form validations and tests for acceleration (#133) * update form validaitons Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots, add skipping validator Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update sqlpage snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add tests for acceleration create Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration builder tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding fix for windows snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * implementing async query support with polling (#131) * successfully getting async post requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * get query with hardcoded job id working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * working spark query after constant time wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added polling with some hardcoded values Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ability to switch between sources implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented basic spinner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small pr asks and cancellation implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixing small clear state issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce route name redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove multiple query implementation for async Signed-off-by: Paul Sebastian <paulstn@amazon.com> * needed to modify the endpoint Signed-off-by: Paul Sebastian <paulstn@amazon.com> * default data source being Opensearch and updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added the skipping index queries, covering index queries,updates the … (#134) * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * reverted updates to yarn Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests, snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Acceleration related changes and minor fixes (#135) * add acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove [if not exists] from acc creation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge tableview from main Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add hash router Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * hide materialized view index type Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * loading combo boxes for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acceleration backend integ Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update jest tests for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add redirection support for home page Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix primary shards count and replica validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove the caution callout for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * support acc flyout redirection from data sources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * disable buttons while running async query (#136) * disable most buttons Signed-off-by: Paul Sebastian <paulstn@amazon.com> * code editor read only Signed-off-by: Paul Sebastian <paulstn@amazon.com> * disabled accelerate button Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Design changes for the sidebar and update to create button (#138) * added changes for loading, create button Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * removed comments, updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots, constant for skipping index Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Load table fields for acceleration index flyout (#137) * load table fields after table is selected Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * simplify the map function Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

* Updated MAINTAINERS.md to match recommended opensearch-project format. (opensearch-project#18) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> * Add .whitesource configuration file (#1) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Bump json5 from 2.2.1 to 2.2.3 (opensearch-project#20) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding release notes (opensearch-project#28) (opensearch-project#30) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 5dde647) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Rename plugin_helpers to plugin-helpers (opensearch-project#31) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add resolution for ansi-regex (opensearch-project#38) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Upgrade hapi-latest to fix CVE-2023-25166 (opensearch-project#39) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Created untriaged issue workflow. (opensearch-project#42) Signed-off-by: dblock <dblock@amazon.com> * Fix Node.js and Yarn installation in CI (opensearch-project#44) Signed-off-by: Miki <miki@amazon.com> * add release notes for 2.6 query workbench (opensearch-project#48) (opensearch-project#50) * add release notes for 2.6 query workbench Signed-off-by: Derek Ho <dxho@amazon.com> * add CI item in infra Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 5cecd8d) Co-authored-by: Derek Ho <dxho@amazon.com> * baseline repo groups (opensearch-project#52) Signed-off-by: Derek Ho <dxho@amazon.com> * Add 2.7 release note (opensearch-project#57) Signed-off-by: Chen Dai <daichen@amazon.com> * Add fix for CVE-2023-2251 (opensearch-project#60) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * update maintainers and code owners (opensearch-project#64) * update maintainers and code owners Signed-off-by: Derek Ho <dxho@amazon.com> * add ani to codeowners Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add release notes for 2.8 (opensearch-project#75) * Add release notes for 2.8 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update release notes Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use valid json for mock data in unit tests (opensearch-project#76) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update default query. (opensearch-project#81) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update CI. (opensearch-project#82) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Increment version to 3.0.0.0 (opensearch-project#66) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Upgrade tough-cookie and semver (opensearch-project#90) * Upgrade tough-cookie to fix CVE-2023-26136 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add semver resolution to patch CVE-2022-25883 Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add release notes for 2.9.0 (opensearch-project#93) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Bump word-wrap from 1.2.3 to 1.2.4 (opensearch-project#99) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update fail backport (opensearch-project#104) Signed-off-by: Derek Ho <dxho@amazon.com> * Update backport CI, add PR merged condition (opensearch-project#111) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update searchbar snapshots according to upstream changes (opensearch-project#115) Signed-off-by: Derek Ho <dxho@amazon.com> * add release notes for 2.10.0 (opensearch-project#117) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Upgrade cypress/request (opensearch-project#120) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add table acceleration flyout (opensearch-project#128) * Add table acceleration flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * comment on hardcoded elements Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * additional comment on hardcoded Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * review fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert version changes, inline type declare Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Increment version to 3.0.0.0 (opensearch-project#121) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add materialized view visual builder and query builders (opensearch-project#129) * add materialized view visual builder and query builders Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * organize header and PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Define tables (opensearch-project#126) * added changes for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added side bar with tables indexed Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added dynamic element for tree view, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * made a few design and panel changes, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the constants file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for search bar removal, pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * readded console.log Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated test suites, removed search field Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for Data connection and combo box Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock for http query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated mock template name in tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed more comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added error message for sidebar Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * update packages and tsconfig (opensearch-project#130) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update form validations and tests for acceleration (opensearch-project#133) * update form validaitons Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots, add skipping validator Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update sqlpage snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add tests for acceleration create Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration builder tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update PR comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding fix for windows snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * implementing async query support with polling (opensearch-project#131) * successfully getting async post requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * get query with hardcoded job id working Signed-off-by: Paul Sebastian <paulstn@amazon.com> * working spark query after constant time wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added polling with some hardcoded values Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ability to switch between sources implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented basic spinner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small pr asks and cancellation implemented Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixing small clear state issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce route name redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove multiple query implementation for async Signed-off-by: Paul Sebastian <paulstn@amazon.com> * needed to modify the endpoint Signed-off-by: Paul Sebastian <paulstn@amazon.com> * default data source being Opensearch and updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added the skipping index queries, covering index queries,updates the … (opensearch-project#134) * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added the skipping index queries, covering index queries,updates the data picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * reverted updates to yarn Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests, snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Acceleration related changes and minor fixes (opensearch-project#135) * add acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove [if not exists] from acc creation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge tableview from main Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add hash router Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * hide materialized view index type Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * loading combo boxes for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding acceleration backend integ Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update jest tests for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add redirection support for home page Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix primary shards count and replica validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove the caution callout for acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * support acc flyout redirection from data sources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * disable buttons while running async query (opensearch-project#136) * disable most buttons Signed-off-by: Paul Sebastian <paulstn@amazon.com> * code editor read only Signed-off-by: Paul Sebastian <paulstn@amazon.com> * disabled accelerate button Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Design changes for the sidebar and update to create button (opensearch-project#138) * added changes for loading, create button Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * removed comments, updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots, constant for skipping index Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Load table fields for acceleration index flyout (opensearch-project#137) * load table fields after table is selected Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * simplify the map function Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Adding minor updates and bug fixes (opensearch-project#140) * adding minor updates to acceleration ui Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * edits to acceleration index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding minor edits to table view Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove console log Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * minor fixes to namings and tableview Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tableview clear db Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Chen Dai <daichen@amazon.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>

sumukhswamy added 2 commits September 16, 2023 16:05

added changes for sidebar

1f28351

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

added side bar with tables indexed

dffcdc6

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

sumukhswamy requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az, MaxKsyunz, Yury-Fridlyand and anirudha as code owners September 21, 2023 06:25

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/app.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 21, 2023

View reviewed changes

public/components/SQLPage/TableView.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 21, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

added dynamic element for tree view, addressed pr comments

f9944e6

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ps48 reviewed Sep 22, 2023

View reviewed changes

public/components/SQLPage/TableView.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 22, 2023

View reviewed changes

public/components/SQLPage/TableView.tsx Outdated Show resolved Hide resolved

sumukhswamy added 2 commits September 22, 2023 17:48

made a few design and panel changes, addressed pr comments

66f1372

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

changed the constants file

2923a5d

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

derek-ho reviewed Sep 28, 2023

View reviewed changes

public/components/Main/main.test.tsx Outdated Show resolved Hide resolved

derek-ho reviewed Sep 28, 2023

View reviewed changes

public/components/Main/main.tsx Outdated Show resolved Hide resolved

joshuali925 reviewed Sep 28, 2023

View reviewed changes

derek-ho requested changes Sep 28, 2023

View reviewed changes

sumukhswamy added 8 commits September 28, 2023 14:33

added changes for search bar removal, pr comments

93e1d39

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

readded console.log

f775a6e

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

updated test suites, removed search field

a604984

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

added changes for Data connection and combo box

02f6baf

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

updated mock for http query

6bc5ad6

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

updated mock template name in tests

aa03a8d

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

addressed pr comments

b19e07d

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

addressed more comments

3aa3948

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ps48 approved these changes Sep 29, 2023

View reviewed changes

derek-ho approved these changes Sep 29, 2023

View reviewed changes

added error message for sidebar

e615ec8

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

joshuali925 approved these changes Sep 29, 2023

View reviewed changes

updated snapshots

ccfa0f5

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ps48 merged commit 8954372 into opensearch-project:main Sep 29, 2023
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define tables #126

Define tables #126

sumukhswamy commented Sep 21, 2023

derek-ho Sep 21, 2023

sumukhswamy Sep 21, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

ps48 commented Sep 28, 2023 •

edited

Loading

derek-ho Sep 28, 2023

sumukhswamy Sep 28, 2023

derek-ho Sep 28, 2023

derek-ho Sep 28, 2023

sumukhswamy Sep 28, 2023

joshuali925 Sep 28, 2023

sumukhswamy Sep 28, 2023

joshuali925 Sep 28, 2023

joshuali925 Sep 29, 2023

sumukhswamy Sep 29, 2023

sumukhswamy Sep 29, 2023

joshuali925 Sep 29, 2023

sumukhswamy Sep 29, 2023 •

edited

Loading

sumukhswamy Sep 29, 2023

derek-ho left a comment

joshuali925 commented Sep 29, 2023

joshuali925 commented Sep 29, 2023

Define tables #126

Define tables #126

Conversation

sumukhswamy commented Sep 21, 2023

Description

Issues Resolved

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

ps48 commented Sep 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sumukhswamy Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derek-ho left a comment

Choose a reason for hiding this comment

joshuali925 commented Sep 29, 2023

joshuali925 commented Sep 29, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

ps48 commented Sep 28, 2023 •

edited

Loading

sumukhswamy Sep 29, 2023 •

edited

Loading