Skip to content

Commit

Permalink
Update document-level-security.md
Browse files Browse the repository at this point in the history 
change of the language used to ensure examples given are clearly defined.

Signed-off-by: leanneeliatra <131779422+leanneeliatra@users.noreply.github.com>
  • Loading branch information
@leanneeliatra
leanneeliatra authored Feb 21, 2024
1 parent 942f97f commit 5854091
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion _security/access-control/document-level-security.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ OpenSearch combines all DLS queries with the logical OR operator. However, when

See the below example where there are two roles defined, one with a DLS specifed and another granting access to search templates, with no DLS specifed.

Check warning on line 193 in _security/access-control/document-level-security.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.DirectionAboveBelow] Use 'following or later' instead of 'below' for versions or orientation within a document. Use 'above' and 'below' only for physical space or screen descriptions.

Raw Output:
{"message": "[OpenSearch.DirectionAboveBelow] Use 'following or later' instead of 'below' for versions or orientation within a document. Use 'above' and 'below' only for physical space or screen descriptions.", "location": {"path": "_security/access-control/document-level-security.md", "range": {"start": {"line": 193, "column": 9}}}, "severity": "WARNING"}

Check failure on line 193 in _security/access-control/document-level-security.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: specifed. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: specifed. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_security/access-control/document-level-security.md", "range": {"start": {"line": 193, "column": 73}}}, "severity": "ERROR"}

Check failure on line 193 in _security/access-control/document-level-security.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: specifed. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: specifed. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_security/access-control/document-level-security.md", "range": {"start": {"line": 193, "column": 143}}}, "severity": "ERROR"}

The role with DLS specified:
```
{
"index_permissions": [
Expand All @@ -207,7 +208,7 @@ See the below example where there are two roles defined, one with a DLS specifed
]
}
```
And one which grants only access to search templates:
The role which grants only access to search templates:
```
{
"index_permissions" : [
Expand All @@ -218,6 +219,7 @@ And one which grants only access to search templates:
]
}
```

To ensure that the role with no DLS takes precedence, add a setting to the `opensearch.yml`:

`plugins.security.dfm_empty_overrides_all: true`
Expand Down

0 comments on commit 5854091

Please sign in to comment.