Documented JDK compatibility for version 1.3.0. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naarcha-AWS
added
upcoming release
Naarcha-AWS
approved these changes
Mar 17, 2022
Naarcha-AWS
removed
the
upcoming release
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
jdk-compatibility
branch
from
61fb534
to
145820b
Compare
|
@Naarcha-AWS Can we get this merged please? The current 1.3.0 docs are incorrect. |
keithhc2
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
The summary of changes can be found in opensearch-project/project-website#670. In this PR I have corrected our compatibility matrix, removing JDK8 from versions 1.0 - 1.2.x, and only including versions that are built with and tested.
I removed the MacOS comment because we bundle a Linux JDK, not a MacOS one, so that's why that doesn't work. If we want to say something about Mac (or Windows), we should link to opensearch-build#33, #37 and #38 for the work remaining on those, but I think it's unnecessary.
Let me know what else needs to change to document the JDK changes, happy to iterate.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.