-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added input parameter validation with few small changes #370
Conversation
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
============================================
+ Coverage 88.43% 88.58% +0.15%
- Complexity 746 752 +6
============================================
Files 91 92 +1
Lines 2697 2708 +11
Branches 215 218 +3
============================================
+ Hits 2385 2399 +14
+ Misses 232 230 -2
+ Partials 80 79 -1
|
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/action/DeleteDatasourceRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com>
for (Map.Entry<String, String> entry : nameToError.entrySet()) { | ||
|
||
// Run | ||
System.out.println(entry.getKey()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Added by mistake.
Description
.
to-
to be consistent with othersIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.