[Backport 2.x] Added input parameter validation with few small changes #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0cfddbf)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
heemin32
approved these changes
Jul 27, 2023
junqiu-lei
approved these changes
Jul 27, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #372 +/- ##
============================================
+ Coverage 88.50% 88.69% +0.19%
- Complexity 746 753 +7
============================================
Files 91 92 +1
Lines 2697 2707 +10
Branches 215 219 +4
============================================
+ Hits 2387 2401 +14
+ Misses 230 228 -2
+ Partials 80 78 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0cfddbf from #371