Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Strings util package with OpenSearch core Strings package #675

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Replace Strings util package with OpenSearch core Strings package #675

merged 1 commit into from
Aug 20, 2024

Conversation

naveentatikonda
Copy link
Member

Description

Replace org.apache.logging.log4j.util.Strings with org.opensearch.core.common.Strings to fix failing CI.
https://github.com/opensearch-project/geospatial/actions/runs/10207619595/job/28962936440?pr=671

> Task :forbiddenApisResources
Forbidden class/interface use: org.apache.logging.log4j.util.Strings [use org.opensearch.core.common.Strings instead.]

  in org.opensearch.geospatial.ip2geo.dao.GeoIpDataDao (GeoIpDataDao.java:233)
> Task :forbiddenApisMain FAILED
Scanned 126 class file(s) for forbidden API invocations (in 0.29s), 1 error(s).


> Task :generateTestEffectiveLombokConfig
FAILURE: Build failed with an exception.


Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
* What went wrong:

Execution failed for task ':forbiddenApisMain'.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda
Replace Strings util package with OpenSearch core Strings package
93f4807 
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda naveentatikonda added backport 2.x Backport PR to 2.x branch skip-changelog labels Aug 20, 2024
@naveentatikonda naveentatikonda merged commit d8fcdae into opensearch-project:main Aug 20, 2024
28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 20, 2024
@naveentatikonda @github-actions
Replace Strings util package with OpenSearch core Strings package (#675)
2368417 
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit d8fcdae)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 20, 2024
Merged
naveentatikonda added a commit that referenced this pull request Aug 20, 2024
@opensearch-trigger-bot @naveentatikonda
Replace Strings util package with OpenSearch core Strings package (#675…
c21b58b 
…) (#676)

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit d8fcdae)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heemin32 heemin32 heemin32 approved these changes

@ryanbogan ryanbogan ryanbogan approved these changes

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport PR to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naveentatikonda @heemin32 @ryanbogan @junqiu-lei