[opensearch] serviceMonitor: add scheme and optional tlsConfig #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
eyenx
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
DandyDeveloper
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
@eyenx We'll want a backport PR as well for 1.X: https://github.com/opensearch-project/helm-charts/blob/main/README.md#version-and-branching
My only Q is this sounds like a patch bump to me on the chart rather than a minor.
|
As it was not fixing anything I thought it was a feature. Will adjust to patchfix if u want. The backport will be done by me as soon as this is merged. |
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
|
I adjusted the bump @DandyDeveloper |
|
@peterzhuamazon LGTM / Ready for merge. |
|
@peterzhuamazon can this be merged? |
|
Thanks @eyenx let me approve and merge this. |
prudhvigodithi
approved these changes
Jan 15, 2025
|
Will backport to v1 in a few hours |
|
Thanks |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds a default scheme and an optional tlsConfig to the serviceMonitor.
Most of the time we are using HTTPS on the OpenSearch Instance.
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.